Add checkstyle and spotbugs #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jogrogan
force-pushed
the
jogrogan/linters
branch
from
6f064ea to
0f5ac44
Compare
ryannedolan
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is broken up by commit.
deploy/subscriptions.crd.yamlneeded to be readded to fix generating models forhoptimator-models. Github doesn't show it nicely but this file was added as a hard link tohoptimator-k8s/subscriptions.crd.yamlThere still exist some checkstyle / spotbugs issues that were not fixed via automation. Both just log as warnings for now but eventually should block PR.