fix(model): fix model tag text

linkernetworks · Apr 27, 2023 · 94610d7 · 94610d7
1 parent ca16673
commit 94610d7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/portal/modules/webmodule/ui/src/components/CVModelDetail/ImageTraining/ImagesSection.tsx b/src/portal/modules/webmodule/ui/src/components/CVModelDetail/ImageTraining/ImagesSection.tsx
@@ -93,7 +93,7 @@ const Images = (props: Props) => {
   }, []);
 
   function onUploadFileInput(e: React.ChangeEvent<HTMLInputElement>): void {
-    for (let i = 0; i < e.target.files.length; i++) {
+    for (let i = 0; i < e.target.files.length; i += 1) {
       const formData = new FormData();
       formData.append('image', e.target.files[i]);
       formData.append('project', modelId.toString());

diff --git a/src/portal/modules/webmodule/ui/src/components/CVModelDetail/ImageTraining/TagsSection.tsx b/src/portal/modules/webmodule/ui/src/components/CVModelDetail/ImageTraining/TagsSection.tsx
@@ -7,16 +7,17 @@ import { Stack, DefaultButton, Label, TextField, Text } from '@fluentui/react';
 
 import { trainingProjectPartsSelectorFactory, postPartByProject } from '../../../store/partSlice';
 import { getTagsClasses } from './styles';
-import { updateCustomVisionProjectTags } from '../../../store/trainingProjectSlice';
+import { ProjectType, updateCustomVisionProjectTags } from '../../../store/trainingProjectSlice';
 
 import Tag from '../../Models/Tag';
 
 interface Props {
   modelId: number;
+  projectType: ProjectType;
 }
 
 const Tags = (props: Props) => {
-  const { modelId } = props;
+  const { modelId, projectType } = props;
 
   const partSelector = useMemo(() => trainingProjectPartsSelectorFactory(modelId), [modelId]);
   const parts = useSelector(partSelector);
@@ -89,7 +90,7 @@ const Tags = (props: Props) => {
             {isAdd && <TextField value={localPart} onChange={(_, newValue) => setLocalPart(newValue)} />}
           </Stack>
           <Stack horizontalAlign="space-between" horizontal>
-            <Text>Add at least 2 tags to Save</Text>
+            <Text>{`Add at least ${projectType === 'Classification' ? '1 tag' : '2 tags'} to Save`}</Text>
             {isAdd ? (
               <DefaultButton
                 className={classes.button}

diff --git a/src/portal/modules/webmodule/ui/src/components/CVModelDetail/ModelTraining.tsx b/src/portal/modules/webmodule/ui/src/components/CVModelDetail/ModelTraining.tsx
@@ -18,7 +18,7 @@ const ModelTraining = (props: Props) => {
 
   return (
     <>
-      <TagsSection modelId={model.id} />
+      <TagsSection modelId={model.id} projectType={model.projectType} />
       <ImagesSection modelId={model.id} />
       <TrainingFooter cvModelId={model.id} projectType={model.projectType} />
     </>