Merge pull request mochajs#985 from jpbochi/async-error-handling

Introducing mocha.throwError for better async error handling

* jpbochi/async-error-handling:
  introduced mocha.throwError for better async error handling

mocha.js

@@ -5569,13 +5569,18 @@ var process = {};
 process.exit = function(status){};
 process.stdout = {};
 
+var uncaughtExceptionHandlers = [];
+
 /**
  * Remove uncaughtException listener.
  */
 
-process.removeListener = function(e){
+process.removeListener = function(e, fn){
   if ('uncaughtException' == e) {
     global.onerror = function() {};
+
+    var indexOfFn = uncaughtExceptionHandlers.indexOf(fn);
+    if (indexOfFn != -1) { uncaughtExceptionHandlers.splice(indexOfFn, 1); }
   }
 };
 
@@ -5588,6 +5593,7 @@ process.on = function(e, fn){
     global.onerror = function(err, url, line){
       fn(new Error(err + ' (' + url + ':' + line + ')'));
     };
+    uncaughtExceptionHandlers.push(fn);
   }
 };
 
@@ -5624,6 +5630,18 @@ Mocha.Runner.immediately = function(callback) {
   }
 };
 
+/**
+ * Function to allow assertion libraries to throw errors directly into mocha.
+ * This is useful when running tests in a browser because window.onerror will
+ * only receive the 'message' attribute of the Error.
+ */
+mocha.throwError = function(err) {
+  uncaughtExceptionHandlers.forEach(function (fn) {
+    fn(err);
+  });
+  throw err;
+};
+
 /**
  * Override ui to ensure that the ui functions are initialized.
  * Normally this would happen in Mocha.prototype.loadFiles.

support/tail.js

@@ -24,13 +24,18 @@ var process = {};
 process.exit = function(status){};
 process.stdout = {};
 
+var uncaughtExceptionHandlers = [];
+
 /**
  * Remove uncaughtException listener.
  */
 
-process.removeListener = function(e){
+process.removeListener = function(e, fn){
   if ('uncaughtException' == e) {
     global.onerror = function() {};
+
+    var indexOfFn = uncaughtExceptionHandlers.indexOf(fn);
+    if (indexOfFn != -1) { uncaughtExceptionHandlers.splice(indexOfFn, 1); }
   }
 };
 
@@ -44,6 +49,7 @@ process.on = function(e, fn){
       fn(new Error(err + ' (' + url + ':' + line + ')'));
       return true;
     };
+    uncaughtExceptionHandlers.push(fn);
   }
 };
 
@@ -85,6 +91,18 @@ Mocha.Runner.immediately = function(callback) {
   }
 };
 
+/**
+ * Function to allow assertion libraries to throw errors directly into mocha.
+ * This is useful when running tests in a browser because window.onerror will
+ * only receive the 'message' attribute of the Error.
+ */
+mocha.throwError = function(err) {
+  uncaughtExceptionHandlers.forEach(function (fn) {
+    fn(err) ;
+  });
+  throw err;
+};
+
 /**
  * Override ui to ensure that the ui functions are initialized.
  * Normally this would happen in Mocha.prototype.loadFiles.

test/browser/large.js

@@ -29,4 +29,21 @@ describe('something', function(){
       done();
     }, 1);
   })
+
+  it('should provide an even better error on phantomjs', function(done){
+    setTimeout(function(){
+      var AssertionError = function(message, actual, expected) {
+        this.message = message;
+        this.actual = actual;
+        this.expected = expected;
+        this.showDiff = true;
+      };
+      AssertionError.prototype = Object.create(Error.prototype);
+      AssertionError.prototype.name = 'AssertionError';
+      AssertionError.prototype.constructor = AssertionError;
+
+      mocha.throwError(new AssertionError('kabooom', 'text with a typo', 'text without a typo'));
+      done();
+    }, 1);
+  })
 })