Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [UIE-8516] - DBaaS: Advanced Configuration (Part 2) - add/remove configs #11885

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

mpolotsk-akamai
Copy link
Contributor

@mpolotsk-akamai mpolotsk-akamai commented Mar 19, 2025

Description πŸ“

DBaaS: Advanced Configuration (Part 2) – Add and Remove Configurations.

This PR continues the implementation of the Drawer functionality, building on the first part.
The first part can be found in PR #11812.

Changes πŸ”„

List any change(s) relevant to the reviewer.

  • Setup Autocomplete to show options with categories
  • Functionality for adding/removing configs
  • PUT call with formatted payload to update database instance with the new config options
  • Dynamic Validation Schema for all types of fields

Target release date πŸ—“οΈ

04/08/25

Preview πŸ“·

Include a screenshot or screen recording of the change.

Before After
Screenshot 2025-03-19 at 4 06 50β€―PM Screenshot 2025-03-19 at 3 56 25β€―PM
Screenshot 2025-03-19 at 4 07 03β€―PM Screenshot 2025-03-19 at 3 56 52β€―PM

How to test πŸ§ͺ

Prerequisites

(How to setup test environment)

  • Database Advanced Config feature flag should be enabled
  • mock data should be enabled

Verification steps

(How to verify changes)

  • select a database cluster
  • navigate to the Advanced Configuration Tab
  • use mock data to see table with existing configurations
  • click 'Configure' button
  • drawer with all existing configurations is shown, the "Save" button is disabled
  • select a new configuration from the Autocomplete and click 'Add' button
  • new configuration is added to the list
  • change the value or click the remove icon to remove this configuration
  • if the configuration has 'restart service' label, the button text changes from 'Save' to 'Save and Restart service'
Author Checklists

As an Author, to speed up the review process, I considered πŸ€”

πŸ‘€ Doing a self review
❔ Our contribution guidelines
🀏 Splitting feature into small PRs
βž• Adding a changeset
πŸ§ͺ Providing/improving test coverage
πŸ” Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
πŸ‘£ Providing comprehensive reproduction steps
πŸ“‘ Providing or updating our documentation
πŸ•› Scheduling a pair reviewing session
πŸ“± Providing mobile support
β™Ώ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed βœ…

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner March 19, 2025 15:23
@mpolotsk-akamai mpolotsk-akamai requested review from dwiley-akamai and bill-akamai and removed request for a team March 19, 2025 15:23
@mpolotsk-akamai mpolotsk-akamai self-assigned this Mar 19, 2025
@mjac0bs mjac0bs added the DBaaS Relates to Database as a Service label Mar 19, 2025
@cpathipa cpathipa requested review from cpathipa and removed request for dwiley-akamai March 19, 2025 18:58
Copy link
Contributor

@bill-akamai bill-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mpolotsk-akamai, confirmed all verification steps

@mpolotsk-akamai mpolotsk-akamai force-pushed the UIE-8515-drawer-add-configs branch from aec0007 to 7d0cf78 Compare March 26, 2025 14:53
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸŽ‰ 534 passing tests on test run #7 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
0 Failing534 Passing4 Skipped108m 43s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants