-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [UIE-8516] - DBaaS: Advanced Configuration (Part 2) - add/remove configs #11885
Open
mpolotsk-akamai
wants to merge
11
commits into
linode:develop
Choose a base branch
from
mpolotsk-akamai:UIE-8515-drawer-add-configs
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
upcoming: [UIE-8516] - DBaaS: Advanced Configuration (Part 2) - add/remove configs #11885
mpolotsk-akamai
wants to merge
11
commits into
linode:develop
from
mpolotsk-akamai:UIE-8515-drawer-add-configs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bill-akamai
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mpolotsk-akamai, confirmed all verification steps
β¦it tests, timezone validation
β¦o display categorized options, add/remove configs, and implement a dynamic validation schema for all field types
aec0007
to
7d0cf78
Compare
Cloud Manager UI test resultsπ 534 passing tests on test run #7 βοΈ
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description π
DBaaS: Advanced Configuration (Part 2) β Add and Remove Configurations.
This PR continues the implementation of the Drawer functionality, building on the first part.
The first part can be found in PR #11812.
Changes π
List any change(s) relevant to the reviewer.
Target release date ποΈ
04/08/25
Preview π·
Include a screenshot or screen recording of the change.
How to test π§ͺ
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered π€
π Doing a self review
β Our contribution guidelines
π€ Splitting feature into small PRs
β Adding a changeset
π§ͺ Providing/improving test coverage
π Removing all sensitive information from the code and PR description
π© Using a feature flag to protect the release
π£ Providing comprehensive reproduction steps
π Providing or updating our documentation
π Scheduling a pair reviewing session
π± Providing mobile support
βΏ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed β