refactor: [M3-9389] - Move Support queries #11904
Merged
+142
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrillo-erik
requested review from
bnussman-akamai and
cliu-akamai
and removed request for
a team
bnussman-akamai
approved these changes
Mar 21, 2025
| SupportReply, | ||
| SupportTicket, | ||
| TicketRequest, | ||
| } from '@linode/api-v4/lib/support'; |
There was a problem hiding this comment.
Optional: clean up all of the imports.
Suggested change
| } from '@linode/api-v4/lib/support'; | |
| } from '@linode/api-v4'; |
Cloud Manager UI test results🎉 533 passing tests on test run #3 ↗︎
|
bnussman-akamai
approved these changes
Mar 24, 2025
| Filter, | ||
| Params, | ||
| ResourcePage, | ||
| } from '@linode/api-v4/lib/types'; |
There was a problem hiding this comment.
Optional: clean up these imports
Suggested change
| } from '@linode/api-v4/lib/types'; | |
| } from '@linode/api-v4'; |
Comment on lines
+31
to
+47
| export const supportQueries = createQueryKeys('support', { | ||
| ticket: (id: number) => ({ | ||
| contextQueries: { | ||
| replies: { | ||
| queryFn: ({ pageParam }) => | ||
| getTicketReplies(id, { page: pageParam as number, page_size: 25 }), | ||
| queryKey: null, | ||
| }, | ||
| }, | ||
| queryFn: () => getTicket(id), | ||
| queryKey: [id], | ||
| }), | ||
| tickets: (params: Params, filter: Filter) => ({ | ||
| queryFn: () => getTickets(params, filter), | ||
| queryKey: [params, filter], | ||
| }), | ||
| }); |
There was a problem hiding this comment.
Optional: I don't remember exactly where we landed on this file-structure wise, but could move the query key factory into a different file just to clean up this file a bit
coliu-akamai
approved these changes
Mar 27, 2025
coliu-akamai
added
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Migrates Support-related queries, as well as all dependencies, under the
@linode/queriespackage.Changes 🔄
support/directory in the@linode/queriespackage with the following structure:packages/manager.TicketList.tsx.How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅