refactor: [M3-7277] - SAST Scan Findings: Path Traversal Vulnerability v2 #11914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bill-akamai
force-pushed
the
M3-7277-sast-scan-findings-path-traversal-vulnerability
branch
from
4a30223 to
0b72d9b
Compare
bill-akamai
force-pushed
the
M3-7277-sast-scan-findings-path-traversal-vulnerability
branch
from
0b72d9b to
5f13994
Compare
bill-akamai
commented
Mar 25, 2025
| // Logic to parse the changeset file and generate the changelog content | ||
| const filePath = path.join(changesetDirectory(linodePackage), file); | ||
| const filePath = changesetDirectory(linodePackage) + path.sep + file; |
There was a problem hiding this comment.
Semgrep specifically flags the use of path.join() with variables at runtime, however this approach should still be safe since changesetDirectory() returns pre-validated paths created at initialization. path.sep is used for cross-platform compatibility for path constructions b/t Windows vs Unix.
bill-akamai
requested review from
dwiley-akamai,
bnussman-akamai and
cpathipa
and removed request for
a team
Cloud Manager UI test results🎉 533 passing tests on test run #5 ↗︎
|
bnussman-akamai
approved these changes
Mar 27, 2025
dwiley-akamai
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR addresses path traversal vulnerabilities identified by SAST security scanning.
Changes 🔄
manager/scripts/directorypath.sepfor cross-platform compatibilityPreview 📷
Prerequisites
semgrepif not already installed withpip install semgrepVerification steps
semgrep --config=p/default scripts/changelog/utils/constants.mjs scripts/changelog/utils/deleteChangesets.mjs scripts/changelog/generate-changelogs.mjs scripts/package-versions/index.js- the output should say "Findings: 0 (0 blocking)".generate-changelogscript still works as expected. Runpnpm run generate-changelogsand you should see an addedCHANGELOG.mdfile added and existing changeset files in.changeset/directories are deleted.package-versionsscript still works as expected. Runpnpm run package-versionsand look for package info output in terminal.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅