Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added grid span feature, and other fixes #18

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

rozenmad
Copy link

@rozenmad rozenmad commented Sep 5, 2021

Grid span feature:

  • Added the ability to expand cells in the grid using the RowSpanAt/ColSpanAt(row, col, size) functions.
  • Added positioning of items in the grid using the align parameter in AddItem(item, row, col, align).
  • In update function added offset from parent for each element (for correct positioning relative to each parent). For example, when the grid is a child of a list, the children of the grid were not positioned correctly relative to the scrolling of the list.
  • New grid example.

I have reworked the OnClick event. Now it is called by pressing any mouse button, but has the parameter which mouse button was pressed. Since sometimes it is required to trigger an event not only on the left mouse button.

Multichoice: new function GetChoiceIndex.
Correct positioning of multichoice-arrow image in skin.

Fixes:
Stencil test for list. Previously, the list in the scrollable list was displayed incorrectly.
Bug that can trigger OnClick events again, even if the mouse cursor is already not hovering over the object.
Bug where "backspace" leads to an incorrect positioning of the text, if it is overflowed 'textinput' element.

- Grid span feature
- Added offset from parent to update each element (for correct positioning relative to each parent)
- OnClick event rework
- Multichoice: new function GetChoiceIndex
- Added positioning of items in the grid using the align parameter in AddItem
- Correct positioning of multichoice-arrow image
- Fixed stencil test for list
- Fixed a bug that can trigger OnClick events again, even if the mouse cursor is not already hovering over the object
- Fixed a bug where "backspace" leads to an incorrect positioning of the entry if the text is overflowed 'textinput' element
@linux-man
Copy link
Owner

Great work! I'll take a look soon.

@linux-man linux-man merged commit 7733210 into linux-man:master Oct 20, 2021
@linux-man
Copy link
Owner

Everything's good.
I'll probably revert one change - the Button right click interaction. Imho is a bad usability decision, counter-intuitive and all other elements (image buttons, checkboxes, radio buttons) don't interact with right click.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants