process: simplify check in previousValueIsValid()

This commit replaces a call to Number.isFinite() with a cheaper typeof check. The subsequent range checks ensure that the checked value is finite. PR-URL: nodejs#24836 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
linvinglor · Dec 7, 2018 · 4ebb3f3 · 4ebb3f3
1 parent df19b07
commit 4ebb3f3
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/internal/process/per_thread.js b/lib/internal/process/per_thread.js
@@ -85,7 +85,7 @@ function setupCpuUsage(_cpuUsage) {
   // Ensure that a previously passed in value is valid. Currently, the native
   // implementation always returns numbers <= Number.MAX_SAFE_INTEGER.
   function previousValueIsValid(num) {
-    return Number.isFinite(num) &&
+    return typeof num === 'number' &&
         num <= Number.MAX_SAFE_INTEGER &&
         num >= 0;
   }