stop using string pointer

pkg/cmd/pr/shared/survey.go

@@ -392,13 +392,5 @@ func FindTemplates(dir, path string) ([]string, string) {
 	templateFiles := githubtemplate.FindNonLegacy(dir, path)
 	legacyTemplate := githubtemplate.FindLegacy(dir, path)
 
-	// TODO stop using string pointer
-
-	lt := ""
-
-	if legacyTemplate != nil {
-		lt = *legacyTemplate
-	}
-
-	return templateFiles, lt
+	return templateFiles, legacyTemplate
 }

pkg/githubtemplate/github_template.go

@@ -53,8 +53,7 @@ mainLoop:
 }
 
 // FindLegacy returns the file path of the default(legacy) template
-func FindLegacy(rootDir string, name string) *string {
-	// TODO why does this return a pointer to string??
+func FindLegacy(rootDir string, name string) string {
 	namePattern := regexp.MustCompile(fmt.Sprintf(`(?i)^%s(\.|$)`, strings.ReplaceAll(name, "_", "[_-]")))
 
 	// https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository
@@ -72,12 +71,11 @@ func FindLegacy(rootDir string, name string) *string {
 		// detect a single template file
 		for _, file := range files {
 			if namePattern.MatchString(file.Name()) && !file.IsDir() {
-				result := path.Join(dir, file.Name())
-				return &result
+				return path.Join(dir, file.Name())
 			}
 		}
 	}
-	return nil
+	return ""
 }
 
 // ExtractName returns the name of the template from YAML front-matter