Skip to content

Commit

Permalink
[pulsar-function] Stop calling the deprated method Thread.stop when s…
Browse files Browse the repository at this point in the history
…topping the function thread in ThreadRuntime. (apache#11401)

* Stop calling the deprated method Thread.stop when stopping the function thread in ThreadRuntime.

* Updated warning message per review comment.
  • Loading branch information
Gimi Liang authored Jul 26, 2021
1 parent 8306158 commit be93e14
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ public void stop() {
// kill the thread
fnThread.join(THREAD_SHUTDOWN_TIMEOUT_MILLIS, 0);
if (fnThread.isAlive()) {
fnThread.stop();
log.warn("The function instance thread is still alive after {} milliseconds. Giving up waiting and moving forward to close function.", THREAD_SHUTDOWN_TIMEOUT_MILLIS);
}
} catch (InterruptedException e) {
// ignore this
Expand Down

0 comments on commit be93e14

Please sign in to comment.