Consistently pass "alwaysRun = true" to all TestNG @after* annotations (

apache#9635)

* Convert Junit 4 test to TestNG test

* Consistently pass "alwaysRun = true" to all TestNG @after* annotations

bouncy-castle/bcfips-include-test/src/test/java/org/apache/pulsar/client/TlsProducerConsumerBase.java

@@ -54,7 +54,7 @@ protected void setup() throws Exception {
         super.init();
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     @Override
     protected void cleanup() throws Exception {
         super.internalCleanup();

managed-ledger/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java

@@ -120,7 +120,7 @@ protected String changeLedgerPath() {
         return "";
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         // stop bookkeeper service
         stopBKCluster();

managed-ledger/src/test/java/org/apache/bookkeeper/test/MockedBookKeeperTestCase.java

@@ -105,7 +105,7 @@ public void setUpClass() {
         cachedExecutor = Executors.newCachedThreadPool();
     }
 
-    @AfterClass
+    @AfterClass(alwaysRun = true)
     public void tearDownClass() {
         executor.shutdown();
         cachedExecutor.shutdown();

pulsar-broker-auth-sasl/src/test/java/org/apache/pulsar/broker/authentication/ProxySaslAuthenticationTest.java

@@ -160,7 +160,7 @@ public static void startMiniKdc() throws Exception {
 		log.info("created AuthenticationSasl");
 	}
 
-	@AfterClass
+	@AfterClass(alwaysRun = true)
 	public static void stopMiniKdc() {
 		System.clearProperty("java.security.auth.login.config");
 		System.clearProperty("java.security.krb5.conf");
@@ -206,7 +206,7 @@ protected void setup() throws Exception {
 	}
 
 	@Override
-	@AfterMethod
+	@AfterMethod(alwaysRun = true)
 	protected void cleanup() throws Exception {
 		super.internalCleanup();
 	}

pulsar-broker-auth-sasl/src/test/java/org/apache/pulsar/broker/authentication/SaslAuthenticateTest.java

@@ -147,7 +147,7 @@ public static void startMiniKdc() throws Exception {
         log.info("created AuthenticationSasl");
     }
 
-    @AfterClass
+    @AfterClass(alwaysRun = true)
     public static void stopMiniKdc() {
         System.clearProperty("java.security.auth.login.config");
         System.clearProperty("java.security.krb5.conf");
@@ -200,7 +200,7 @@ protected void setup() throws Exception {
         super.producerBaseSetup();
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     @Override
     protected void cleanup() throws Exception {
         super.internalCleanup();

pulsar-broker-common/src/test/java/org/apache/pulsar/broker/authentication/AuthenticationProviderListTest.java

@@ -125,7 +125,7 @@ public void setUp() throws Exception {
             Optional.of(new Date(System.currentTimeMillis() + TimeUnit.SECONDS.toMillis(3))));
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         this.authProvider.close();
     }

pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ConsumedLedgersTrimTest.java

@@ -49,7 +49,7 @@ protected void setup() throws Exception {
         //No-op
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     @Override
     protected void cleanup() throws Exception {
         super.internalCleanup();

pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java

@@ -61,7 +61,7 @@ protected void setup() throws Exception {
         resetConfig();
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     protected void cleanup() throws Exception {
         super.internalCleanup();
     }

pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/SubscriptionStatsTest.java

@@ -47,7 +47,7 @@ protected void setup() throws Exception {
         super.producerBaseSetup();
     }
 
-    @AfterClass
+    @AfterClass(alwaysRun = true)
     @Override
     protected void cleanup() throws Exception {
         super.internalCleanup();

pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/pendingack/PendingAckInMemoryDeleteTest.java

@@ -89,7 +89,7 @@ protected void setup() throws Exception {
         Thread.sleep(1000 * 3);
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     protected void cleanup() {
         super.internalCleanup();
     }

pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MultiTopicsReaderTest.java

@@ -71,7 +71,7 @@ protected void setup() throws Exception {
         admin.namespaces().createNamespace("my-property/my-ns", Sets.newHashSet("test"));
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     @Override
     protected void cleanup() throws Exception {
         super.internalCleanup();

pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/utils/IOUtilsTest.java

@@ -39,7 +39,7 @@ public class IOUtilsTest {
     InputStream stdin = System.in;
     PrintStream stdout = System.out;
 
-    @AfterClass
+    @AfterClass(alwaysRun = true)
     public void tearDown() {
         System.setIn(stdin);
         System.setOut(stdout);

pulsar-client-tools-test/src/test/java/org/apache/pulsar/client/cli/PulsarClientToolWsTest.java

@@ -44,7 +44,7 @@ protected void setup() throws Exception {
         super.internalSetup();
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     @Override
     protected void cleanup() throws Exception {
         super.resetConfig();

pulsar-client/src/test/java/org/apache/pulsar/client/impl/AcknowledgementsGroupingTrackerTest.java

@@ -72,7 +72,7 @@ public Object[][] isNeedReceipt() {
         return new Object[][] { { Boolean.TRUE }, { Boolean.FALSE } };
     }
 
-    @AfterClass
+    @AfterClass(alwaysRun = true)
     public void teardown() {
         eventLoopGroup.shutdownGracefully();
     }

pulsar-client/src/test/java/org/apache/pulsar/client/impl/ClientCnxRequestTimeoutQueueTest.java

@@ -66,7 +66,7 @@ void setupClientCnx() throws Exception {
         requestMessage = mock(ByteBuf.class);
     }
 
-    @AfterTest
+    @AfterTest(alwaysRun = true)
     void cleanupClientCnx() {
         eventLoop.shutdownNow();
     }

pulsar-client/src/test/java/org/apache/pulsar/client/impl/MemoryLimitControllerTest.java

@@ -40,7 +40,7 @@ void setup() {
         executor = Executors.newCachedThreadPool();
     }
 
-    @AfterClass
+    @AfterClass(alwaysRun = true)
     void teardown() {
         executor.shutdownNow();
     }

pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/DefaultSchemasTest.java

@@ -79,7 +79,7 @@ public void testStringSchema() throws Exception {
         assertEquals(stringSchemaUtf16.encode(testString), bytes2);
     }
 
-    @AfterClass
+    @AfterClass(alwaysRun = true)
     public void tearDown() throws PulsarClientException {
         client.close();
     }

pulsar-common/src/test/java/org/apache/pulsar/common/util/netty/ChannelFuturesTest.java

@@ -53,7 +53,7 @@ public void initEventLoop() {
         eventLoop = new DefaultEventLoop();
     }
 
-    @AfterTest
+    @AfterTest(alwaysRun = true)
     public void shutdownEventLoop() throws InterruptedException {
         eventLoop.shutdownGracefully(0, 0, TimeUnit.MILLISECONDS).await(100);
     }

pulsar-discovery-service/src/test/java/org/apache/pulsar/discovery/service/web/DiscoveryServiceWebTest.java

@@ -88,7 +88,7 @@ private void init() throws Exception {
         start();
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     private void cleanup() throws Exception {
         close();
     }

pulsar-discovery-service/src/test/java/org/apache/pulsar/discovery/service/web/ZookeeperCacheLoaderTest.java

@@ -47,7 +47,7 @@ private void init() throws Exception {
         start();
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     private void cleanup() throws Exception {
         close();
     }

pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactoryTest.java

@@ -131,7 +131,7 @@ public KubernetesRuntimeFactoryTest() throws Exception {
         this.logDirectory = "logs/functions";
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() {
         if (null != this.factory) {
             this.factory.close();

pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeTest.java

@@ -174,7 +174,7 @@ public void setup() {
         System.setProperty(FUNCTIONS_INSTANCE_CLASSPATH, "/pulsar/lib/*");
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() {
         if (null != this.factory) {
             this.factory.close();

pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/process/ProcessRuntimeTest.java

@@ -138,7 +138,7 @@ public void setup() {
         System.setProperty(FUNCTIONS_INSTANCE_CLASSPATH, "/pulsar/lib/*");
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() {
         if (null != this.factory) {
             this.factory.close();

pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/ClusterServiceCoordinatorTest.java

@@ -75,7 +75,7 @@ public void setup() throws Exception {
     }
 
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void teardown() {
         coordinator.close();
 

pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/FunctionMetaDataTopicTailerTest.java

@@ -64,7 +64,7 @@ public FunctionMetaDataTopicTailerTest() throws Exception {
                 ErrorNotifier.getDefaultImpl());
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         fsc.close();
         verify(reader, times(1)).close();

pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/SchedulerManagerTest.java

@@ -137,7 +137,7 @@ public void setup() {
         schedulerManager.setLeaderService(leaderService);
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void stop() {
         this.executor.shutdown();
     }

pulsar-io/debezium/core/src/test/java/org/apache/pulsar/io/debezium/PulsarDatabaseHistoryTest.java

@@ -61,7 +61,7 @@ protected void setup() throws Exception {
         this.history = new PulsarDatabaseHistory();
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     @Override
     protected void cleanup() throws Exception {
         super.internalCleanup();

pulsar-io/elastic-search/src/test/java/org/apache/pulsar/io/elasticsearch/ElasticSearchSinkTests.java

@@ -88,7 +88,7 @@ public byte[] answer(InvocationOnMock invocation) throws Throwable {
             }});
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public final void tearDown() throws Exception {
         sink.close();
     }

pulsar-io/file/src/test/java/org/apache/pulsar/io/file/AbstractFileTests.java

@@ -68,7 +68,7 @@ public void init() throws IOException {
         executor = Executors.newFixedThreadPool(10);
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         // Shutdown all of the processing threads
         stopThreads();

pulsar-io/flume/src/test/java/org/apache/pulsar/io/flume/sink/StringSinkTests.java

@@ -103,7 +103,7 @@ public String answer(InvocationOnMock invocation) throws Throwable {
         });
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         source.stop();
     }

pulsar-io/flume/src/test/java/org/apache/pulsar/io/flume/source/StringSourceTests.java

@@ -71,7 +71,7 @@ public void setUp() throws Exception {
         mockSourceContext = mock(SourceContext.class);
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         sink.stop();
         sink = null;

pulsar-io/influxdb/src/test/java/org/apache/pulsar/io/influxdb/v1/InfluxDBGenericRecordSinkTest.java

@@ -100,7 +100,7 @@ public void setUp() throws Exception {
         when(influxSink.influxDBBuilder.build(any())).thenReturn(influxDB);
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         influxSink.close();
         verify(influxDB, times(1)).close();

pulsar-io/jdbc/sqlite/src/test/java/org/apache/pulsar/io/jdbc/JdbcUtilsTest.java

@@ -45,7 +45,7 @@ public void setUp() throws IOException, SQLException {
         sqliteUtils.setUp();
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws IOException, SQLException {
         sqliteUtils.tearDown();
     }

pulsar-io/jdbc/sqlite/src/test/java/org/apache/pulsar/io/jdbc/SqliteJdbcSinkTest.java

@@ -104,7 +104,7 @@ public void setUp() throws Exception {
 
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         sqliteUtils.tearDown();
         jdbcSink.close();

pulsar-io/kafka-connect-adaptor/src/test/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSourceTest.java

@@ -71,7 +71,7 @@ protected void setup() throws Exception {
 
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     @Override
     protected void cleanup() throws Exception {
         tempFile.delete();

pulsar-io/kafka-connect-adaptor/src/test/java/org/apache/pulsar/io/kafka/connect/PulsarOffsetBackingStoreTest.java

@@ -66,7 +66,7 @@ protected void setup() throws Exception {
         this.offsetBackingStore.start();
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     @Override
     protected void cleanup() throws Exception {
         if (null != offsetBackingStore) {

pulsar-io/mongo/src/test/java/org/apache/pulsar/io/mongodb/MongoSinkTest.java

@@ -126,7 +126,7 @@ private void initFailContext(String msg) {
         }).when(mockPublisher).subscribe(any());
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         sink.close();
         verify(mockMongoClient, times(1)).close();

pulsar-io/mongo/src/test/java/org/apache/pulsar/io/mongodb/MongoSourceTest.java

@@ -107,7 +107,7 @@ public void setUp() {
         }).when(mockPublisher).subscribe(any());
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         source.close();
         verify(mockMongoClient, times(1)).close();

pulsar-io/rabbitmq/src/test/java/org/apache/pulsar/io/rabbitmq/sink/RabbitMQSinkTest.java

@@ -40,7 +40,7 @@ public void setUp() throws Exception {
         rabbitMQBrokerManager.startBroker();
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         rabbitMQBrokerManager.stopBroker();
     }

pulsar-io/rabbitmq/src/test/java/org/apache/pulsar/io/rabbitmq/source/RabbitMQSourceTest.java

@@ -37,7 +37,7 @@ public void setUp() throws Exception {
         rabbitMQBrokerManager.startBroker();
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         rabbitMQBrokerManager.stopBroker();
     }

pulsar-io/redis/src/test/java/org/apache/pulsar/io/redis/sink/RedisSinkTest.java

@@ -45,7 +45,7 @@ public void setUp() throws Exception {
         embeddedRedisUtils.setUp();
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         embeddedRedisUtils.tearDown();
     }

pulsar-io/solr/src/test/java/org/apache/pulsar/io/solr/SolrGenericRecordSinkTest.java

@@ -64,7 +64,7 @@ public void setUp() throws Exception {
         solrServerUtil.startStandaloneSolr();
     }
 
-    @AfterMethod
+    @AfterMethod(alwaysRun = true)
     public void tearDown() throws Exception {
         solrServerUtil.stopStandaloneSolr();
     }