Skip to content

Commit

Permalink
Make compact view default (mlflow#700)
Browse files Browse the repository at this point in the history
Originally, we made the compact view non-default because it didn't support column-splitting or persistence -- now that we have both of these, we should go ahead and make this view default. Users can still switch back to the old view, and that choice will be persisted.

Also switched ordering of the icons so the default is on the left.
  • Loading branch information
aarondav authored and mateiz committed Nov 9, 2018
1 parent 228dbfb commit 1b09159
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions mlflow/server/js/src/components/ExperimentView.js
Original file line number Diff line number Diff line change
Expand Up @@ -390,20 +390,20 @@ class ExperimentView extends Component {
</Button>
<span style={{cursor: "pointer"}}>
<ButtonGroup style={styles.tableToggleButtonGroup}>
<Button
onClick={() => this.setShowMultiColumns(true)}
title="Grid view"
className={classNames({ "active": this.state.persistedState.showMultiColumns })}
>
<i className={"fas fa-table"}/>
</Button>
<Button
onClick={() => this.setShowMultiColumns(false)}
title="Compact view"
className={classNames({ "active": !this.state.persistedState.showMultiColumns })}
>
<i className={"fas fa-list"}/>
</Button>
<Button
onClick={() => this.setShowMultiColumns(true)}
title="Grid view"
className={classNames({ "active": this.state.persistedState.showMultiColumns })}
>
<i className={"fas fa-table"}/>
</Button>
</ButtonGroup>
</span>
</div>
Expand Down
2 changes: 1 addition & 1 deletion mlflow/server/js/src/sdk/MlflowLocalStorageMessages.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const ExperimentViewPersistedState = Immutable.Record({
key: "start_time"
},
// If true, shows the multi-column table view instead of the compact table view.
showMultiColumns: true,
showMultiColumns: false,
// Arrays of "unbagged", or split-out metric and param keys (strings). We maintain these as lists
// to help keep them ordered (i.e. splitting out a column shouldn't change the ordering of columns
// that have already been split out)
Expand Down

0 comments on commit 1b09159

Please sign in to comment.