Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from Lit monorepo (manually) #23

Closed
wants to merge 24 commits into from
Closed

Conversation

AndrewJakubowicz
Copy link
Contributor

No description provided.

kevinpschaaf and others added 24 commits February 5, 2021 00:41
* Add tsconfig for dowleveling polyfill-support to ES5

* Feature detect when patching as opposed to load
Makes the polyfill-support agnostic to wcjs load ordering

* Inject polyfill-support into tests when needed; add styling test

* Add sauce and browserstack examples

* Make super call ES5 downlevel-safe

* Pass super args and tear off Reflect.construct

* Avoid Reflect.construct

* Fix ENABLE_SHADYDOM_NOPATCH replacement when downleveling

* Warn on unconfigured browser

* Replace var to var for ES5
1. Updates all license headers to new concise SPDX style
2. Updates copyright statement holder from The Polymer Project Authors to Google LLC
3. Trivial formatting fix to LICENSE files so that we exactly match the spdx.org text
4. Updates package.json author field to Google LLC

All existing years are preserved, and for files that didn't have a copyright statement, I used the year that that filename was first checked into git.
Replaces // msgdesc comments with a new desc property on the msg options object.

Why
---
A msg option is trivial to parse, and almost impossible for the user to misuse, because of type checking. Comments can be tricky to associate with AST nodes correctly, and silently fail when in the wrong place or typo'd.

The recursive behavior of // msgdesc: was unusual and not worth the complexity.

This approach will allow future runtime access to the description which, while won't be used by the standard runtime, does open the door for a future dev mode that supports e.g. hovering to see descriptions, or even setting translations directly.

Cost
----
This does regress byte size for runtime mode applications that are currently minified with comment stripping. However, once we have a transform for runtime mode (#1469), we'll be able to remove comments there (in addition to hard-coding IDs so that we can skip template hashing).
* Add @lit-labs/ssr-client and move renderLight

* Ensure .d.ts are copied to root

* Sync ignore

* Downlevel to ES2019
* Update package-lock.json files.

* Bump versions in package.json and CHANGELOG.md files.

* Regenerate package-lock files.

* Update URLs
* Run `npm audit fix` in starter kits

* Update the starter kits' dependencies.
Updates ssr & starte templates to next major change to @open-wc/testing compatible with lit.
Adds configureReentrantLocalization in @lit/localize/init/reentrant.js which allows for safe concurrent rendering across multiple locales by asynchronous tasks.

Adds configureSsrLocalization in @lit/localize-tools/lib/ssr.js which combines configureReentrantLocalization with AsyncLocalStorage to produce a withLocale function that makes it simple to do safe concurrent localized rendering with global-mode @lit-labs/ssr or another renderer.
… from the polyfills. (#2016)

* Temporarily add local tarball based off of the `ts-externs` branch in webcomponents/polyfills.

* Update packages to use temporary polyfills tarball.

* Update webcomponentsjs tarball.

* Update lit-html to use the polyfills' TS externs.

* Update reactive-element to use the polyfills' TS externs.

* Update lit-element to use the polyfills' TS externs.

* Update package-lock.json files with `npx lerna bootstrap` (i.e. without `--ci`).

* Update webcomponentsjs tarball.

* Replace local polyfills tarball with `@webcomponents/webcomponentsjs@^2.6.0`.
…override` modifier on overridden fields (#2060)

* Update TypeScript

* Bump prettier

* Enable noImplicitOverride in lit-html

* Enable noImplicitOverride in lit-element

* Enable noImplicitOverride in reactive-element

* Enable noImplicitOverride in labs/task

* Enable noImplicitOverride in labs/react

* Enable noImplicitOverride in benchmarks

* Enable noImplicitOverride in ssr-client

* Enable noImplicitOverride in labs/scoped-registry-mixin

* Enable noImplicitOverride in labs/motion

* Enable noImplicitOverride in lit-starter-ts

* Enable noImplicitOverride in labs/ssr

* Enable noImplicitOverride in all remaining packages (no changes to code needed)

* Add changeset.

* Update new ts-transformers tests.
- Upgrade all package locks. Includes TypeScript 4.3.5 -> 4.4.2.
- Typing fixes for TypeScript 4.4.2 (mostly https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#use-unknown-catch-variables)
- Adds `devDependency` on new `@types/web-ie11` package to address microsoft/TypeScript-DOM-lib-generator#1068
- Upgrade `xmldom` to new `@xmldom/xmldom` due to xmldom/xmldom#271
- Pin the localize transform example to TypeScript ~4.3.5 due to rollup/plugins#983
- Add missing `@types/node` dependency to `internal-scripts` (not sure why this wasn't an error before -- maybe the Node types were coming via a transitive dependency which was removed by an upgrade).
- Minor `@lit/localize-tools` changes: don't run `build` as part of `test` script, use `@lit/ssr` bare module in test instead of relative path, trivial config file schema change from dependency upgrade.
Bumps almost all of our dependencies to the latest major versions.

It was almost entirely devDependencies apart from:

@types/trusted-types in lit-html
parse5 in @lit-labs/ssr
fs-extra in @lit/localize-tools
No code upgrades were needed apart from the parse5 update in @lit-labs/ssr.

Build and test is still passing. I looked through all the CHANGELOGs for anything that looked like it might break us, but didn't see any. I also manually ran all of these demos since they aren't tested:

@lit/localize runtime and transform demos
@lit-labs/ssr global and vm-modules demos
@lit/lit-starter-js and @lit/lit-starter-ts docs demos
* Update package exports in `lit-html`.

* Update package exports in `@lit/reactive-element`.

* Update package exports in `lit-element`.

* Update package exports in `lit`.

* Update package exports in `@lit-labs/ssr-client`.

* Add a changeset.

* Update `@web/dev-server` in `@lit/lit-starter-js` and `@lit/lit-starter-ts`.

* Add config for running tests in dev mode

* Sync ignores

* Default to dev mode for serving

Co-authored-by: Kevin Schaaf <[email protected]>
* Update from WCA to CEM generator

* Remove generated custom-elements.json manifest from git

* Fix formatting

* Add changeset

* Fix TS return type in docs generator

* Update package-lock for starter kits

* Update package-lock
Just did an npm run upgrade.

Want to make sure a fresh cache will be built, and that the next PR that lands will use it.

The cache that is currently saved is actually not as useful as it could be, because I ran it before I noticed the problem documented here: https://github.com/lit/lit/blob/main/.github/workflows/tests.yml#L17
* Update to GA versions

* Hand curate major release changelogs

* Remove pre-release/candidate status from READMEs

* Bump versions reported in code

* Update package-locks

* Revert changeset updateInternalDependencies to minor

* Revert extra spaces added by formatter

* Apply suggestions from code review

Co-authored-by: Steve Orvell <[email protected]>

* Update versions in starter changelogs

Co-authored-by: Steve Orvell <[email protected]>
…s:serve` (#2300)

We want to specify no root directory, such that the README.md instructions
make sense. Therefore, by navigating the localhost:8000/dev/index.html
as written, you now get your authored element and a much better experience.

Previously `npm run serve` was serving the docs directory preventing
access to the component.

* Add something on root url, so that folks don't get a 404.

We recommend in the README.md that the user navigates to
/dev/index.html. However you expect `npm run serve` to not
404.

Add a tiny stub document that points users in the right direction.

Co-authored-by: Andrew Jakubowicz <[email protected]>
@AndrewJakubowicz AndrewJakubowicz deleted the bugfix-serve branch December 8, 2021 21:19
@AndrewJakubowicz AndrewJakubowicz restored the bugfix-serve branch December 8, 2021 21:43
@AndrewJakubowicz AndrewJakubowicz deleted the bugfix-serve branch December 8, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants