Skip to content

Commit

Permalink
minix: drop vmtruncate
Browse files Browse the repository at this point in the history
Removed vmtruncate

Signed-off-by: Marco Stornelli <[email protected]>
Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
Marco Stornelli authored and Al Viro committed Dec 20, 2012
1 parent 5dfc282 commit 7fc7cd0
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 7 deletions.
6 changes: 4 additions & 2 deletions fs/minix/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,12 @@ static int minix_setattr(struct dentry *dentry, struct iattr *attr)

if ((attr->ia_valid & ATTR_SIZE) &&
attr->ia_size != i_size_read(inode)) {
error = vmtruncate(inode, attr->ia_size);
error = inode_newsize_ok(inode, attr->ia_size);
if (error)
return error;

truncate_setsize(inode, attr->ia_size);
minix_truncate(inode);
}

setattr_copy(inode, attr);
Expand All @@ -45,7 +48,6 @@ static int minix_setattr(struct dentry *dentry, struct iattr *attr)
}

const struct inode_operations minix_file_inode_operations = {
.truncate = minix_truncate,
.setattr = minix_setattr,
.getattr = minix_getattr,
};
17 changes: 12 additions & 5 deletions fs/minix/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,16 @@ int minix_prepare_chunk(struct page *page, loff_t pos, unsigned len)
return __block_write_begin(page, pos, len, minix_get_block);
}

static void minix_write_failed(struct address_space *mapping, loff_t to)
{
struct inode *inode = mapping->host;

if (to > inode->i_size) {
truncate_pagecache(inode, to, inode->i_size);
minix_truncate(inode);
}
}

static int minix_write_begin(struct file *file, struct address_space *mapping,
loff_t pos, unsigned len, unsigned flags,
struct page **pagep, void **fsdata)
Expand All @@ -403,11 +413,8 @@ static int minix_write_begin(struct file *file, struct address_space *mapping,

ret = block_write_begin(mapping, pos, len, flags, pagep,
minix_get_block);
if (unlikely(ret)) {
loff_t isize = mapping->host->i_size;
if (pos + len > isize)
vmtruncate(mapping->host, isize);
}
if (unlikely(ret))
minix_write_failed(mapping, pos + len);

return ret;
}
Expand Down

0 comments on commit 7fc7cd0

Please sign in to comment.