Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variable name for source to avoid function name conflict #1105

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

phongnh
Copy link
Contributor

@phongnh phongnh commented Dec 12, 2024

Hi @liuchengxu,

I am adding PR to update variable name from Source to ClapProviderSource to avoid function name conflict. In my case, I have a Source function to source vim config. I can change my config to fix this issue but I think that Source is quite common function name, others can be affected by this error as well. Please help me to review and accept this PR if you find it does make senses, thanks.

Error detected while processing function clap#[45]..clap#open_provider[23]..<SNR>45_detect_source_type:
line    1:
E705: Variable name conflicts with existing function: Source

```
Error detected while processing function clap#[45]..clap#open_provider[23]..<SNR>45_detect_source_type:
line    1:
E705: Variable name conflicts with existing function: Source
```
@liuchengxu
Copy link
Owner

Look good to me. CI failure is unrelated.

@liuchengxu liuchengxu merged commit 66b6154 into liuchengxu:master Dec 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants