Skip to content

Commit

Permalink
[AVR] Fix and clean up the inline assembly tests
Browse files Browse the repository at this point in the history
There was a bug where we would hit an assertion if 'Q' was used as a
constraint.

I also removed hardcoded register names to prefer regexes so the tests
don't break when the register allocator changes.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@289325 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
Dylan McKay committed Dec 10, 2016
1 parent c2e1f83 commit 08e478d
Show file tree
Hide file tree
Showing 5 changed files with 341 additions and 338 deletions.
4 changes: 3 additions & 1 deletion lib/Target/AVR/AVRISelDAGToDAG.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,9 @@ bool AVRDAGToDAGISel::SelectInlineAsmMemoryOperand(const SDValue &Op,
std::vector<SDValue> &OutOps) {
// Yes hardcoded 'm' symbol. Just because it also has been hardcoded in
// SelectionDAGISel (callee for this method).
assert(ConstraintCode == InlineAsm::Constraint_m && "Unexpected asm memory constraint");
assert(ConstraintCode == InlineAsm::Constraint_m ||
ConstraintCode == InlineAsm::Constraint_Q &&
"Unexpected asm memory constraint");

MachineRegisterInfo &RI = MF->getRegInfo();
const AVRSubtarget &STI = MF->getSubtarget<AVRSubtarget>();
Expand Down
337 changes: 0 additions & 337 deletions test/CodeGen/AVR/inline-asm.ll

This file was deleted.

Loading

0 comments on commit 08e478d

Please sign in to comment.