Skip to content

Commit

Permalink
[Orc][RPC] Remove a couple of redundant calls to abandonAllPendingRes…
Browse files Browse the repository at this point in the history
…ponses.

appendCallAsync, which all RPC call functions ultimately build on, will call
abandonAllPendingResponses on channel error. These extra calls are redundant.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@293405 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
lhames committed Jan 29, 2017
1 parent 5cfd78f commit 11bb3e4
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions include/llvm/ExecutionEngine/Orc/RPCUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,6 @@ class MultiThreadedRPCEndpoint
return Error::success();
},
Args...)) {
this->abandonPendingResponses();
RTraits::consumeAbandoned(FutureResult.get());
return std::move(Err);
}
Expand Down Expand Up @@ -1188,12 +1187,6 @@ class MultiThreadedRPCEndpoint
typename detail::ResultTraits<AltRetT>::ErrorReturnType
callB(const ArgTs &... Args) {
if (auto FutureResOrErr = callNB<Func>(Args...)) {
if (auto Err = this->C.send()) {
this->abandonPendingResponses();
detail::ResultTraits<typename Func::ReturnType>::consumeAbandoned(
std::move(FutureResOrErr->get()));
return std::move(Err);
}
return FutureResOrErr->get();
} else
return FutureResOrErr.takeError();
Expand Down

0 comments on commit 11bb3e4

Please sign in to comment.