Skip to content

Commit

Permalink
Enable disabled loopidiom test. Apparently we handle it now
Browse files Browse the repository at this point in the history
Summary:
Enable disabled loopidiom test. Apparently we handle it now.
Maybe due to improvements to AA.

Reviewers: atrick, danielcdh, hfinkel

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D28171

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@290900 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
trentxintong committed Jan 3, 2017
1 parent 2aa90f6 commit efca1a3
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions test/Transforms/LoopIdiom/basic.ll
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,7 @@ for.end: ; preds = %entry
; CHECK: ret void
}


;; TODO: We should be able to promote this memset. Not yet though.
; Make sure the first store in the loop is turned into a memset.
define void @test4(i8* %Base) nounwind ssp {
bb.nph: ; preds = %entry
%Base100 = getelementptr i8, i8* %Base, i64 1000
Expand All @@ -118,9 +117,8 @@ for.body: ; preds = %bb.nph, %for.body

for.end: ; preds = %for.body, %entry
ret void
; CHECK-TODO-LABEL: @test4(
; CHECK-TODO: call void @llvm.memset.p0i8.i64(i8* %Base, i8 0, i64 100, i32 1, i1 false)
; CHECK-TODO-NOT: store
; CHECK-LABEL: @test4(
; CHECK: call void @llvm.memset.p0i8.i64(i8* %Base, i8 0, i64 100, i32 1, i1 false)
}

; This can't be promoted: the memset is a store of a loop variant value.
Expand Down

0 comments on commit efca1a3

Please sign in to comment.