Skip to content

Commit

Permalink
[Data] Deflake Data CI test suites: test_stats, `test_streaming_exe…
Browse files Browse the repository at this point in the history
…cutor`, `test_object_gc` (ray-project#40457)

test_stats, test_streaming_executor tests in the Data CI are flakey, each due to a single problematic unit test. To un-flake the rest of each test suite, we temporarily disable the problematic unit tests while we investigate the issues, so that we can get as many Data tests back on the regular test pipeline for everyone.

---------

Signed-off-by: Scott Lee <[email protected]>
  • Loading branch information
scottjlee authored Oct 18, 2023
1 parent b60c172 commit 4d93e37
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
3 changes: 0 additions & 3 deletions ci/ray_ci/data.tests.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
flaky_tests:
- //python/ray/data:test_streaming_executor
- //python/ray/data:test_streaming_integration
- //python/ray/data:test_split
- //python/ray/data:test_object_gc
- //python/ray/data:test_stats
4 changes: 4 additions & 0 deletions python/ray/data/tests/test_stats.py
Original file line number Diff line number Diff line change
Expand Up @@ -974,6 +974,10 @@ def test_get_total_stats(ray_start_regular_shared, stage_two_block):
assert dataset_stats_summary.get_max_heap_memory() == peak_memory_stats.get("max")


@pytest.mark.skip(
reason="Temporarily disable to deflake rest of test suite. "
"See: https://github.com/ray-project/ray/pull/40173"
)
def test_streaming_stats_full(ray_start_regular_shared, restore_data_context):
DataContext.get_current().new_execution_backend = True
DataContext.get_current().use_streaming_executor = True
Expand Down
4 changes: 4 additions & 0 deletions python/ray/data/tests/test_streaming_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,10 @@ def stub(res: ExecutionResources) -> TopologyResourceUsage:
)


@pytest.mark.skip(
reason="Temporarily disable to deflake rest of test suite. Started being flaky "
"after moving to civ2? Needs further investigation to confirm."
)
def test_resource_constrained_triggers_autoscaling(monkeypatch):
RESOURCE_REQUEST_TIMEOUT = 5
monkeypatch.setattr(
Expand Down

0 comments on commit 4d93e37

Please sign in to comment.