Skip to content

Commit

Permalink
Remove TEST_ENV variable
Browse files Browse the repository at this point in the history
Karma doesn't support loading ES modules, so all this was doing was
using Babel to translate everything back to CommonJS before testing
anyway, which kinda defeats the purpose of testing multiple builds.
  • Loading branch information
mjackson committed Dec 3, 2019
1 parent 0ada9c2 commit 434fe90
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 15 deletions.
4 changes: 0 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ cache: yarn
jobs:
include:
- stage: Test
env: TEST_ENV=source
script: yarn test
- env: TEST_ENV=umd
before_script: yarn build
script: yarn test
- stage: Size
before_script: yarn build
Expand Down
12 changes: 1 addition & 11 deletions karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,6 @@ module.exports = function(config) {
// },
};

var historyAlias;
switch (process.env.TEST_ENV) {
case 'umd':
historyAlias = 'umd/history.js';
break;
case 'source':
default:
historyAlias = 'modules/index.js';
}

config.set({
customLaunchers: customLaunchers,
browsers: ['Chrome' /*, 'Firefox'*/],
Expand All @@ -94,7 +84,7 @@ module.exports = function(config) {
},
resolve: {
alias: {
history$: path.resolve(__dirname, historyAlias)
history$: path.resolve(__dirname, 'modules/index.js')
}
},
plugins: [
Expand Down

0 comments on commit 434fe90

Please sign in to comment.