Skip to content

Commit

Permalink
TODO: Remove "OpenFlow Group Bucket Stats" from TODO list
Browse files Browse the repository at this point in the history
Signed-off-by: Ryan Wilson <[email protected]>
Signed-off-by: Ben Pfaff <[email protected]>
  • Loading branch information
Ryan Wilson authored and blp committed May 22, 2014
1 parent 9edf6b4 commit 79a2458
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions TODO
Original file line number Diff line number Diff line change
Expand Up @@ -52,23 +52,6 @@ These changes might have backward-compatibility implications; one
would have to test the behavior of the reduced cipher list OVS against
older versions.

OpenFlow Group Bucket Stats
---------------------------

When OpenFlow group support was added, we forgot to support statistics
for individual buckets. xlate_group_bucket() in
ofproto/ofproto-dpif-xlate.c appears to be where we need to increment
the counters, in the case where ctx->xin->resubmit_stats is
nonnull. See the ovs-dev thread starting here:
http://openvswitch.org/pipermail/dev/2014-January/036107.html

Joe Stringer adds: If this involves resubmit_stats, then it would also
need a new xc_type. The xlate_group_bucket() code would add an entry
to ctx->xin->xcache if it is nonnull. This would also need to follow
the code in xlate_push_stats() and xlate_cache_clear() for the new
xc_type.


Bash Command Completion
-----------------------

Expand Down

0 comments on commit 79a2458

Please sign in to comment.