forked from apache/flink
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FLINK-12763][runtime] Factor out SlotManager tests for eager failing…
… of unfulfillable requests Turning the one monolithic test into multile targeted tests makes it easier to test specific scenarios and makes the tests easier readable.
- Loading branch information
1 parent
faacb55
commit 1d01ed8
Showing
3 changed files
with
215 additions
and
59 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
211 changes: 211 additions & 0 deletions
211
...rg/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerFailUnfulfillableTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,211 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.runtime.resourcemanager.slotmanager; | ||
|
|
||
| import org.apache.flink.api.common.JobID; | ||
| import org.apache.flink.runtime.clusterframework.types.AllocationID; | ||
| import org.apache.flink.runtime.clusterframework.types.ResourceID; | ||
| import org.apache.flink.runtime.clusterframework.types.ResourceProfile; | ||
| import org.apache.flink.runtime.clusterframework.types.SlotID; | ||
| import org.apache.flink.runtime.concurrent.Executors; | ||
| import org.apache.flink.runtime.resourcemanager.ResourceManagerId; | ||
| import org.apache.flink.runtime.resourcemanager.SlotRequest; | ||
| import org.apache.flink.runtime.resourcemanager.registration.TaskExecutorConnection; | ||
| import org.apache.flink.runtime.taskexecutor.SlotReport; | ||
| import org.apache.flink.runtime.taskexecutor.SlotStatus; | ||
| import org.apache.flink.runtime.taskexecutor.TaskExecutorGateway; | ||
| import org.apache.flink.runtime.taskexecutor.TestingTaskExecutorGatewayBuilder; | ||
| import org.apache.flink.util.TestLogger; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.fail; | ||
|
|
||
| /** | ||
| * Tests for setting the SlotManager to eagerly fail unfulfillable requests. | ||
| */ | ||
| public class SlotManagerFailUnfulfillableTest extends TestLogger { | ||
|
|
||
| @Test | ||
| public void testTurnOnKeepsPendingFulfillableRequests() throws Exception { | ||
| // setup | ||
| final ResourceProfile availableProfile = new ResourceProfile(2.0, 100); | ||
| final ResourceProfile fulfillableProfile = new ResourceProfile(1.0, 100); | ||
|
|
||
| final SlotManager slotManager = createSlotManagerNotStartingNewTMs(); | ||
| registerFreeSlot(slotManager, availableProfile); | ||
|
|
||
| slotManager.registerSlotRequest(slotRequest(fulfillableProfile)); | ||
| slotManager.registerSlotRequest(slotRequest(fulfillableProfile)); | ||
|
|
||
| // test | ||
| slotManager.setFailUnfulfillableRequest(true); | ||
|
|
||
| // assert | ||
| assertEquals(1, slotManager.getNumberPendingSlotRequests()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTurnOnCancelsPendingUnFulfillableRequests() throws Exception { | ||
| // setup | ||
| final ResourceProfile availableProfile = new ResourceProfile(2.0, 100); | ||
| final ResourceProfile unfulfillableProfile = new ResourceProfile(1.0, 200); | ||
|
|
||
| final List<AllocationID> allocationFailures = new ArrayList<>(); | ||
| final SlotManager slotManager = createSlotManagerNotStartingNewTMs(allocationFailures); | ||
| registerFreeSlot(slotManager, availableProfile); | ||
|
|
||
| // test | ||
| final SlotRequest request = slotRequest(unfulfillableProfile); | ||
| slotManager.registerSlotRequest(request); | ||
| slotManager.setFailUnfulfillableRequest(true); | ||
|
|
||
| // assert | ||
| assertEquals(1, allocationFailures.size()); | ||
| assertEquals(request.getAllocationId(), allocationFailures.get(0)); | ||
| // assertEquals(0, slotManager.getNumberPendingSlotRequests()); // BUG, to be fixed in follow-up commit | ||
| } | ||
|
|
||
| @Test | ||
| public void testTurnOnKeepsRequestsWithStartingTMs() throws Exception { | ||
| // setup | ||
| final ResourceProfile availableProfile = new ResourceProfile(2.0, 100); | ||
| final ResourceProfile newTmProfile = new ResourceProfile(2.0, 200); | ||
|
|
||
| final SlotManager slotManager = createSlotManagerStartingNewTMs(); | ||
| registerFreeSlot(slotManager, availableProfile); | ||
|
|
||
| // test | ||
| slotManager.registerSlotRequest(slotRequest(newTmProfile)); | ||
| slotManager.setFailUnfulfillableRequest(true); | ||
|
|
||
| // assert | ||
| assertEquals(1, slotManager.getNumberPendingSlotRequests()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testFulfillableRequestsKeepPendingWhenOn() throws Exception { | ||
| // setup | ||
| final ResourceProfile availableProfile = new ResourceProfile(2.0, 100); | ||
|
|
||
| final SlotManager slotManager = createSlotManagerNotStartingNewTMs(); | ||
| registerFreeSlot(slotManager, availableProfile); | ||
| slotManager.setFailUnfulfillableRequest(true); | ||
|
|
||
| // test | ||
| slotManager.registerSlotRequest(slotRequest(availableProfile)); | ||
| slotManager.registerSlotRequest(slotRequest(availableProfile)); | ||
|
|
||
| // assert | ||
| assertEquals(1, slotManager.getNumberPendingSlotRequests()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testUnfulfillableRequestsFailWhenOn() throws Exception { | ||
| // setup | ||
| final ResourceProfile availableProfile = new ResourceProfile(2.0, 100); | ||
| final ResourceProfile unfulfillableProfile = new ResourceProfile(2.0, 200); | ||
|
|
||
| final List<AllocationID> notifiedAllocationFailures = new ArrayList<>(); | ||
| final SlotManager slotManager = createSlotManagerNotStartingNewTMs(notifiedAllocationFailures); | ||
| registerFreeSlot(slotManager, availableProfile); | ||
| slotManager.setFailUnfulfillableRequest(true); | ||
|
|
||
| // test | ||
| try { | ||
| slotManager.registerSlotRequest(slotRequest(unfulfillableProfile)); | ||
| fail("this should cause an exception"); | ||
| } | ||
| catch (SlotManagerException ignored) {} | ||
|
|
||
| // assert | ||
| assertEquals(0, notifiedAllocationFailures.size()); | ||
| assertEquals(0, slotManager.getNumberPendingSlotRequests()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testStartingTmKeepsSlotPendingWhenOn() throws Exception { | ||
| // setup | ||
| final ResourceProfile availableProfile = new ResourceProfile(2.0, 100); | ||
| final ResourceProfile newTmProfile = new ResourceProfile(2.0, 200); | ||
|
|
||
| final SlotManager slotManager = createSlotManagerStartingNewTMs(); | ||
| registerFreeSlot(slotManager, availableProfile); | ||
| slotManager.setFailUnfulfillableRequest(true); | ||
|
|
||
| // test | ||
| slotManager.registerSlotRequest(slotRequest(newTmProfile)); | ||
|
|
||
| // assert | ||
| assertEquals(1, slotManager.getNumberPendingSlotRequests()); | ||
| } | ||
|
|
||
| // ------------------------------------------------------------------------ | ||
| // helper | ||
| // ------------------------------------------------------------------------ | ||
|
|
||
| private static SlotManager createSlotManagerNotStartingNewTMs() { | ||
| return createSlotManager(new ArrayList<>(), false); | ||
| } | ||
|
|
||
| private static SlotManager createSlotManagerNotStartingNewTMs(List<AllocationID> notifiedAllocationFailures) { | ||
| return createSlotManager(notifiedAllocationFailures, false); | ||
| } | ||
|
|
||
| private static SlotManager createSlotManagerStartingNewTMs() { | ||
| return createSlotManager(new ArrayList<>(), true); | ||
| } | ||
|
|
||
| private static SlotManager createSlotManager( | ||
| List<AllocationID> notifiedAllocationFailures, | ||
| boolean startNewTMs) { | ||
|
|
||
| final ResourceActions resourceManagerActions = new TestingResourceActionsBuilder() | ||
| .setAllocateResourceFunction((resourceProfile) -> startNewTMs ? | ||
| Collections.singleton(resourceProfile) : | ||
| Collections.emptyList()) | ||
| .setNotifyAllocationFailureConsumer(tuple3 -> notifiedAllocationFailures.add(tuple3.f1)) | ||
| .build(); | ||
|
|
||
| SlotManager slotManager = SlotManagerBuilder.newBuilder().build(); | ||
| slotManager.start(ResourceManagerId.generate(), Executors.directExecutor(), resourceManagerActions); | ||
|
|
||
| return slotManager; | ||
| } | ||
|
|
||
| private static void registerFreeSlot(SlotManager slotManager, ResourceProfile slotProfile) { | ||
| final ResourceID resourceID = ResourceID.generate(); | ||
| final TaskExecutorGateway taskExecutorGateway = new TestingTaskExecutorGatewayBuilder().createTestingTaskExecutorGateway(); | ||
| final TaskExecutorConnection taskExecutorConnection = new TaskExecutorConnection(resourceID, taskExecutorGateway); | ||
|
|
||
| final SlotReport slotReport = new SlotReport( | ||
| Collections.singleton(new SlotStatus(new SlotID(resourceID, 0), slotProfile))); | ||
|
|
||
| slotManager.registerTaskManager(taskExecutorConnection, slotReport); | ||
| } | ||
|
|
||
| private static SlotRequest slotRequest(ResourceProfile profile) { | ||
| return new SlotRequest(new JobID(), new AllocationID(), profile, "foobar"); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters