Skip to content

Commit

Permalink
spi/imx: correct the test on platform_get_irq() return value
Browse files Browse the repository at this point in the history
The test "if (spi_imx->irq <= 0)" is not testing the IRQ value, but
the return value of platform_get_irq().  As platform_get_irq() can
return an error (-ENXIO) or the IRQ value it found, the test should be
"if (spi_imx->irq < 0)"

[grant.likely: Note: In general, Linux irq number 0 should also mean
no irq, but arm still allows devices to be assigned 0, and the imx
platform uses 0 for one of the spi devices, so this patch is needed
for the device to work]

Signed-off-by: Richard Genoud <[email protected]>
Signed-off-by: Grant Likely <[email protected]>
  • Loading branch information
rgenoud authored and glikely committed Jan 7, 2011
1 parent 77e58ef commit 7357593
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/spi/spi_imx.c
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,7 @@ static int __devinit spi_imx_probe(struct platform_device *pdev)
}

spi_imx->irq = platform_get_irq(pdev, 0);
if (spi_imx->irq <= 0) {
if (spi_imx->irq < 0) {
ret = -EINVAL;
goto out_iounmap;
}
Expand Down

0 comments on commit 7357593

Please sign in to comment.