Skip to content

Commit

Permalink
Revert "task_struct: make journal_info conditional"
Browse files Browse the repository at this point in the history
This reverts commit e4c570c, as
requested by Alexey:

 "I think I gave a good enough arguments to not merge it.
  To iterate:
   * patch makes impossible to start using ext3 on EXT3_FS=n kernels
     without reboot.
   * this is done only for one pointer on task_struct"

  None of config options which define task_struct are tristate directly
  or effectively."

Requested-by: Alexey Dobriyan <[email protected]>
Acked-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
torvalds committed Dec 17, 2009
1 parent a2770d8 commit b6e3224
Show file tree
Hide file tree
Showing 10 changed files with 1 addition and 20 deletions.
4 changes: 0 additions & 4 deletions fs/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ menu "File systems"

if BLOCK

config FS_JOURNAL_INFO
bool
default n

source "fs/ext2/Kconfig"
source "fs/ext3/Kconfig"
source "fs/ext4/Kconfig"
Expand Down
1 change: 0 additions & 1 deletion fs/btrfs/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ config BTRFS_FS
select LIBCRC32C
select ZLIB_INFLATE
select ZLIB_DEFLATE
select FS_JOURNAL_INFO
help
Btrfs is a new filesystem with extents, writable snapshotting,
support for multiple devices and many more features.
Expand Down
1 change: 0 additions & 1 deletion fs/ext4/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ config EXT4_FS
tristate "The Extended 4 (ext4) filesystem"
select JBD2
select CRC16
select FS_JOURNAL_INFO
help
This is the next generation of the ext3 filesystem.

Expand Down
1 change: 0 additions & 1 deletion fs/gfs2/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ config GFS2_FS
select SLOW_WORK
select QUOTA
select QUOTACTL
select FS_JOURNAL_INFO
help
A cluster filesystem.

Expand Down
1 change: 0 additions & 1 deletion fs/jbd/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
config JBD
tristate
select FS_JOURNAL_INFO
help
This is a generic journalling layer for block devices. It is
currently used by the ext3 file system, but it could also be
Expand Down
1 change: 0 additions & 1 deletion fs/jbd2/Kconfig
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
config JBD2
tristate
select CRC32
select FS_JOURNAL_INFO
help
This is a generic journaling layer for block devices that support
both 32-bit and 64-bit block numbers. It is currently used by
Expand Down
1 change: 0 additions & 1 deletion fs/nilfs2/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ config NILFS2_FS
tristate "NILFS2 file system support (EXPERIMENTAL)"
depends on EXPERIMENTAL
select CRC32
select FS_JOURNAL_INFO
help
NILFS2 is a log-structured file system (LFS) supporting continuous
snapshotting. In addition to versioning capability of the entire
Expand Down
1 change: 0 additions & 1 deletion fs/reiserfs/Kconfig
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
config REISERFS_FS
tristate "Reiserfs support"
select CRC32
select FS_JOURNAL_INFO
help
Stores not just filenames but the files themselves in a balanced
tree. Uses journalling.
Expand Down
8 changes: 1 addition & 7 deletions include/linux/init_task.h
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,6 @@ extern struct cred init_cred;
# define INIT_PERF_EVENTS(tsk)
#endif

#ifdef CONFIG_FS_JOURNAL_INFO
#define INIT_JOURNAL_INFO .journal_info = NULL,
#else
#define INIT_JOURNAL_INFO
#endif

/*
* INIT_TASK is used to set up the first task table, touch at
* your own risk!. Base=0, limit=0x1fffff (=2MB)
Expand Down Expand Up @@ -168,6 +162,7 @@ extern struct cred init_cred;
.signal = {{0}}}, \
.blocked = {{0}}, \
.alloc_lock = __SPIN_LOCK_UNLOCKED(tsk.alloc_lock), \
.journal_info = NULL, \
.cpu_timers = INIT_CPU_TIMERS(tsk.cpu_timers), \
.fs_excl = ATOMIC_INIT(0), \
.pi_lock = __RAW_SPIN_LOCK_UNLOCKED(tsk.pi_lock), \
Expand All @@ -178,7 +173,6 @@ extern struct cred init_cred;
[PIDTYPE_SID] = INIT_PID_LINK(PIDTYPE_SID), \
}, \
.dirties = INIT_PROP_LOCAL_SINGLE(dirties), \
INIT_JOURNAL_INFO \
INIT_IDS \
INIT_PERF_EVENTS(tsk) \
INIT_TRACE_IRQFLAGS \
Expand Down
2 changes: 0 additions & 2 deletions include/linux/sched.h
Original file line number Diff line number Diff line change
Expand Up @@ -1446,10 +1446,8 @@ struct task_struct {
gfp_t lockdep_reclaim_gfp;
#endif

#ifdef CONFIG_FS_JOURNAL_INFO
/* journalling filesystem info */
void *journal_info;
#endif

/* stacked block device info */
struct bio *bio_list, **bio_tail;
Expand Down

0 comments on commit b6e3224

Please sign in to comment.