xfs: fix ->mknod() return value on xfs_get_acl() failure

->mknod() should return negative on errors and PTR_ERR() gives already negative value... Signed-off-by: Al Viro <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Alex Elder <[email protected]>
liveeasily · Jun 14, 2011 · c46a131 · c46a131
1 parent 59c5f46
commit c46a131
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c
@@ -182,7 +182,7 @@ xfs_vn_mknod(
 	if (IS_POSIXACL(dir)) {
 		default_acl = xfs_get_acl(dir, ACL_TYPE_DEFAULT);
 		if (IS_ERR(default_acl))
-			return -PTR_ERR(default_acl);
+			return PTR_ERR(default_acl);
 
 		if (!default_acl)
 			mode &= ~current_umask();