-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Rime TTS #1206
Support Rime TTS #1206
Conversation
|
@patrickscoleman could you give me access to the forked repo? I'd like to clean up a couple of things and get this across the finish line. |
No problem, thank you! Just gave you access to: https://github.com/patrickscoleman/livekit-agents-add-rime |
@davidzhao Hey David! Just following up here. let us know if you need anything from our side to get this over the finish line! |
Hi @patrickscoleman @liliest, |
from .log import logger | ||
from .models import TTSModels, TTSEncoding | ||
|
||
_Encoding = Literal["pcm", "mp3", "x-mulaw"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is it diffrent from TTSEncoding
?
"mulaw": "audio/x-mulaw", | ||
} | ||
|
||
def _sampling_rate_from_format(output_format: TTSEncoding) -> int | None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modelId: TTSModels | str = DEFAULT_MODEL_ID, | ||
speaker: str = DEFAULT_SPEAKER, | ||
audioFormat: TTSEncoding | _Encoding = "wav", | ||
samplingRate: int | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename this to sample_rate
to keep consistency with other tts plugins
url = self._opts.api_url | ||
headers = { | ||
"accept": ACCEPT_HEADER[self._opts.audioFormat], | ||
AUTHORIZATION_HEADER: f"Bearer {self._opts.api_key}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Authorization"
hi @jayeshp19 ! can you sign up for our 'free trial' plan and then try again? thanks so much for looking at this! |
Oh we manually have to subscribe, I thought I was subscribed for free plan already when I made an account. Checking now! |
@jayeshp19 apologies, our flow is bad and currently being reworked :) |
Moved these changese to #1377 with some cleanup |
Closing this since #1377 has been merged into the main branch. |
What
This PR implements Rime support for TTS
Why
Feature Improvement
Docs
https://rimelabs.mintlify.app/api-reference/quickstart