Skip to content

Commit

Permalink
Deprecate IE11, de-flake tests (google#1975)
Browse files Browse the repository at this point in the history
* smaller model for fidelity tests

* removed legacy bundle

* extra test for flake

* removed IS_IE11

* skip test on iOS

* updated docs
  • Loading branch information
elalish authored Jan 26, 2021
1 parent 725380b commit 17aba79
Show file tree
Hide file tree
Showing 44 changed files with 996 additions and 26,641 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/deploy-documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@ jobs:
- name: Build packages
run: npm run build

- name: Generate legacy bundles
run: npm run build:legacy-support

- name: Generate fidelity artifacts
uses: GabrielBB/[email protected]
with:
Expand Down
12 changes: 1 addition & 11 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,4 @@ jobs:
BROWSER_STACK_USERNAME: ${{ secrets.BROWSER_STACK_USERNAME }}
BROWSER_STACK_ACCESS_KEY: ${{ secrets.BROWSER_STACK_ACCESS_KEY }}
BROWSER_STACK_BUILD_NAME: ${{ format('{0} / {1}', github.ref, github.run_id) }}
run: npm run test:ci

- name: Generate legacy bundles
run: npm run build:legacy-support

- name: Unit tests (legacy browsers)
env:
BROWSER_STACK_USERNAME: ${{ secrets.BROWSER_STACK_USERNAME }}
BROWSER_STACK_ACCESS_KEY: ${{ secrets.BROWSER_STACK_ACCESS_KEY }}
BROWSER_STACK_BUILD_NAME: ${{ format('{0} / {1}', github.ref, github.run_id) }}
run: npm run test:ci:legacy
run: npm run test:ci
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ Command | Description
------------------------------ | -----------
`npm run bootstrap` | Bootstraps the project for development and cross-links sub-projects
`npm run build` | Runs the build step for all sub-projects
`npm run build:legacy-support` | Builds JS bundles that have IE11 support
`npm run serve` | Runs a web server and opens a new browser tab pointed to the local copy of modelviewer.dev (don't forget to build!)
`npm run test` | Runs tests in all sub-projects that have them
`npm run clean` | Removes built artifacts from all sub-projects
Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@
"scripts": {
"test": "./node_modules/.bin/lerna run test --stream",
"test:ci": "./node_modules/.bin/lerna run test:ci --stream",
"test:ci:legacy": "./node_modules/.bin/lerna run test:ci:legacy --stream",
"bootstrap": "./node_modules/.bin/lerna bootstrap --ci",
"format": "find packages/**/src -name '*.ts' | grep -v .d.ts | xargs ./node_modules/.bin/clang-format --verbose -i",
"lint": "./node_modules/.bin/eslint \"packages/**/*.ts\"",
"lint:fix": "npm run lint -- --fix",
"clean": "./node_modules/.bin/lerna run clean --stream",
"build": "./node_modules/.bin/lerna run build --stream",
"build:legacy-support": "./node_modules/.bin/lerna run create-legacy-bundles --stream",
"serve": "./node_modules/.bin/http-server -a 127.0.0.1 -o /packages/modelviewer.dev -c-1",
"update:package-lock": "rm ./package-lock.json && npm i --only=production && ./node_modules/.bin/lerna run update:package-lock --stream"
},
Expand Down
3,017 changes: 49 additions & 2,968 deletions packages/editing-adapter/package-lock.json

Large diffs are not rendered by default.

229 changes: 0 additions & 229 deletions packages/model-viewer/POLYFILLS.md

This file was deleted.

16 changes: 5 additions & 11 deletions packages/model-viewer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ It can also be used directly from various free CDNs such as [unpkg.com](https://

```html
<script type="module" src="https://unpkg.com/@google/model-viewer/dist/model-viewer.min.js"></script>
<script nomodule src="https://unpkg.com/@google/model-viewer/dist/model-viewer-legacy.js"></script>
```

For more detailed usage documentation and live examples, please visit our docs
Expand Down Expand Up @@ -68,20 +67,16 @@ below with the full version number (like `0.10.0`) to be pinned to.
## Browser Support

`<model-viewer>` is supported on the last 2 major versions of all evergreen
desktop and mobile browsers. `<model-viewer>` is also supported on IE11.
desktop and mobile browsers.

| | <img src="https://github.com/alrra/browser-logos/raw/master/src/chrome/chrome_32x32.png" width="16"> Chrome | <img src="https://github.com/alrra/browser-logos/raw/master/src/firefox/firefox_32x32.png" width="16"> Firefox | <img src="https://github.com/alrra/browser-logos/raw/master/src/safari/safari_32x32.png" width="16"> Safari | <img src="https://github.com/alrra/browser-logos/raw/master/src/edge/edge_32x32.png" width="16"> Edge | <img src="https://github.com/alrra/browser-logos/raw/master/src/archive/internet-explorer_9-11/internet-explorer_9-11_32x32.png" width="16"> IE11 |
| -------- | --- | --- | --- | --- | --- |
| Desktop ||||||
| Mobile ||||| N/A |
| | <img src="https://github.com/alrra/browser-logos/raw/master/src/chrome/chrome_32x32.png" width="16"> Chrome | <img src="https://github.com/alrra/browser-logos/raw/master/src/firefox/firefox_32x32.png" width="16"> Firefox | <img src="https://github.com/alrra/browser-logos/raw/master/src/safari/safari_32x32.png" width="16"> Safari | <img src="https://github.com/alrra/browser-logos/raw/master/src/edge/edge_32x32.png" width="16"> Edge |
| -------- | --- | --- | --- | --- |
| Desktop |||||
| Mobile |||||

`<model-viewer>` builds upon standard web platform APIs so that the performance,
capabilities and compatibility of the library get better as the web evolves.

However, not all browsers support all of these features today. **Check out
[POLYFILLS.md](https://github.com/google/model-viewer/blob/master/packages/model-viewer/POLYFILLS.md) to
learn how to polyfill for maximum browser compatibility!**

## Development

To get started, follow the instructions in [the main README.md file](../../README.md).
Expand All @@ -94,6 +89,5 @@ Command | Description
`npm run build:dev` | Builds a subset of distributable files (faster than `npm run build`)
`npm run test` | Run `<model-viewer>` unit tests
`npm run clean` | Deletes all build artifacts
`npm run create-legacy-bundles` | Generates IE11-compatible bundles (run `npm run build` first)
`npm run dev` | Starts `tsc` and `rollup` in "watch" mode, causing artifacts to automatically rebuild upon incremental changes

Loading

0 comments on commit 17aba79

Please sign in to comment.