Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default switch behavior #33

Merged
merged 8 commits into from
Aug 23, 2013
Merged

Default switch behavior #33

merged 8 commits into from
Aug 23, 2013

Conversation

matteoagosti
Copy link
Contributor

  • TAB and SHIFT+TAB are ignored, and won't trigger the switch as they are used differently by browsers (TAB means move to the next focusable/tabbable element that is not necessarily a content editable)
  • ARROW KEYS trigger the switch. We should improve the UP/DOWN management when on FIRST/LAST line of a block; currently the cursor get first moved to the BEGINNING/END and only after that the switch is triggered, so you need to press twice.

@matteoagosti
Merge pull request #27 from beyounic/mergeBehavior
36f97f4 
Merge behavior, fixes to insert behavior, fixes to cursor position detection
@matteoagosti
Small refactor to make consistent all methods: work with dom elements…
2e3159d 
… and manipulate them directly
@matteoagosti
Preserving initial white spaces on new line
ac6de74
@matteoagosti
HTML tags normalization on blur. Completely fixes #24
88650d1 
- Needs some test spec
- IDs are considered in the attributes check as when you split a tag
the browser will preserve ids (awkard stuff); we may relax this
requirement
@matteoagosti
Few tests for parser.isSameNode
2b03ca8
@matteoagosti
Adding one nested tag in sample page
df53ef3
@matteoagosti
Bug fix when dealing with nested tags
c05557c
@matteoagosti
Test suite for normalizeTags
0b053a1
@matteoagosti matteoagosti merged this pull request into mergeBehavior Aug 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteoagosti @peyerluk