Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been glancing over the codebase and there's one thing that I found to be a bit too verbose. In
src/cursor.js
there are several methods that havethe
in their names.isAtTheEnd
isAtTheBeginning
moveAtTheEnd
moveAtTheBeginning
In my opinion, these would read nicer without
the
. Also, if I understood themove
methods correctly, they move the cursor before or after an element. Wouldn't it make more sense to name themmoveTo{End,Beginning}
or maybe evenmove{Before,After}Element
?