Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include required dependencies for testing #8

Closed
wants to merge 1 commit into from

Conversation

download13
Copy link
Contributor

I added some dependencies to the devDependencies that are required for testing but only work if installed globally.

Excluding global dependencies from package.json can save some space, but it can discourage new contributors who don't know what to do when they npm run <something> and everything immediately fails.

@codecov-io
Copy link

Current coverage is 98.01%

Merging #8 into master will increase coverage by 3.87%

  1. 4 files (not in diff) in lib were modified. more
    • Misses +3
    • Partials -10
    • Hits +21
@@           master         #8   diff @@
========================================
  Files           4          4          
  Lines         188        202    +14   
  Methods         0         24    +24   
  Branches       41         55    +14   
========================================
+ Hits          177        198    +21   
- Misses          1          4     +3   
+ Partials       10          0    -10   

Powered by Codecov. Last updated by c05e363...928ccce

@download13
Copy link
Contributor Author

Umm.... I don't know why those changes would've upped the code coverage, but.... good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants