tag/ApeLoader: remove exception handler, let caller catch

lizhengdao · Jan 18, 2020 · bdd3167 · bdd3167
1 parent 526c778
commit bdd3167
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/src/tag/ApeLoader.hxx b/src/tag/ApeLoader.hxx
@@ -31,6 +31,8 @@ typedef std::function<bool(unsigned long flags, const char *key,
 /**
  * Scans the APE tag values from a file.
  *
+ * Throws on I/O error.
+ *
  * @return false if the file could not be opened or if no APE tag is
  * present
  */

diff --git a/src/tag/ApeReplayGain.hxx b/src/tag/ApeReplayGain.hxx
@@ -23,6 +23,9 @@
 class InputStream;
 struct ReplayGainInfo;
 
+/**
+ * Throws on I/O error.
+ */
 bool
 replay_gain_ape_read(InputStream &is, ReplayGainInfo &info);
 

diff --git a/src/tag/ApeTag.cxx b/src/tag/ApeTag.cxx
@@ -68,7 +68,7 @@ tag_ape_import_item(unsigned long flags,
 }
 
 bool
-tag_ape_scan2(InputStream &is, TagHandler &handler) noexcept
+tag_ape_scan2(InputStream &is, TagHandler &handler)
 {
 	bool recognized = false;
 

diff --git a/src/tag/ApeTag.hxx b/src/tag/ApeTag.hxx
@@ -26,9 +26,11 @@ class TagHandler;
 /**
  * Scan the APE tags of a stream.
  *
+ * Throws on I/O error.
+ *
  * @param path_fs the path of the file in filesystem encoding
  */
 bool
-tag_ape_scan2(InputStream &is, TagHandler &handler) noexcept;
+tag_ape_scan2(InputStream &is, TagHandler &handler);
 
 #endif
-Original file line number
+Diff line change
@@ Expand Up / @@ -68,7 +68,7 @@ tag_ape_import_item(unsigned long flags, @@
     }
     bool
-    tag_ape_scan2(InputStream &is, TagHandler &handler) noexcept
+    tag_ape_scan2(InputStream &is, TagHandler &handler)
     {
     	bool recognized = false;
@@ Expand Down @@