Skip to content

Commit

Permalink
Remove rule_sets construct
Browse files Browse the repository at this point in the history
Restrict the processor to a single array of rules. This is similar to the structure of the signature utilities, but it instantiates the rules with configuration. This moves rules out of configuration, and out of the required_config population change. To keep the rules happy, all necessary configuration for rules has moved to the Processor_2015 class and is passed to rules at initialization in the `config` variable. Required config options are left on the rules to support testing.
  • Loading branch information
lonnen committed Feb 21, 2018
1 parent 898181b commit 0be35ff
Show file tree
Hide file tree
Showing 3 changed files with 232 additions and 292 deletions.
2 changes: 1 addition & 1 deletion socorro/processor/breakpad_transform_rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ def _action(self, raw_crash, raw_dumps, processed_crash, processor_meta):

dump_file_pathname = raw_dumps[dump_name]

if self.config.chatty:
if self.config.get('chatty'):
self.config.logger.debug(
"BreakpadStackwalkerRule2015: %s, %s",
dump_name,
Expand Down
Loading

0 comments on commit 0be35ff

Please sign in to comment.