Fix maze skins crashing if larger than max

Off by one error on length. Setting &skin=9 in the URL would clamp down to 3, instead of 2. This crashed the page.
lkiarest · Nov 8, 2021 · 07cbe40 · 07cbe40
1 parent 2e1caaf
commit 07cbe40
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/appengine/maze/js/maze.js b/appengine/maze/js/maze.js
@@ -92,7 +92,8 @@ Maze.SKINS = [
     crashType: Maze.CRASH_FALL
   }
 ];
-Maze.SKIN_ID = BlocklyGames.getNumberParamFromUrl('skin', 0, Maze.SKINS.length);
+Maze.SKIN_ID =
+    BlocklyGames.getNumberParamFromUrl('skin', 0, Maze.SKINS.length - 1);
 Maze.SKIN = Maze.SKINS[Maze.SKIN_ID];
 
 /**