fix: stop word update (janhq#1457)

* fix: stop word update * fix: enable stop settings --------- Co-authored-by: hahuyhoang411 <[email protected]>
ll2l · Jan 11, 2024 · 19153c4 · 19153c4
1 parent 163bc72
commit 19153c4
Show file tree

Hide file tree

Showing 26 changed files with 31 additions and 9 deletions.
diff --git a/extensions/model-extension/package.json b/extensions/model-extension/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@janhq/model-extension",
-  "version": "1.0.20",
+  "version": "1.0.21",
   "description": "Model Management Extension provides model exploration and seamless downloads",
   "main": "dist/index.js",
   "module": "dist/module.js",

diff --git a/models/capybara-34b/model.json b/models/capybara-34b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/codeninja-1.0-7b/model.json b/models/codeninja-1.0-7b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": ["<|end_of_turn|>"],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/deepseek-coder-1.3b/model.json b/models/deepseek-coder-1.3b/model.json
@@ -16,6 +16,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/deepseek-coder-34b/model.json b/models/deepseek-coder-34b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/dolphin-2.7-mixtral-8x7b/model.json b/models/dolphin-2.7-mixtral-8x7b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/llama2-chat-70b-q4/model.json b/models/llama2-chat-70b-q4/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/llama2-chat-7b-q4/model.json b/models/llama2-chat-7b-q4/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/mistral-ins-7b-q4/model.json b/models/mistral-ins-7b-q4/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/mixtral-8x7b-instruct/model.json b/models/mixtral-8x7b-instruct/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/noromaid-7b/model.json b/models/noromaid-7b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/openchat-3.5-7b/model.json b/models/openchat-3.5-7b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": ["<|end_of_turn|>"],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/openhermes-neural-7b/model.json b/models/openhermes-neural-7b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/phi-2-3b/model.json b/models/phi-2-3b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/phind-34b/model.json b/models/phind-34b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/solar-10.7b-slerp/model.json b/models/solar-10.7b-slerp/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/starling-7b/model.json b/models/starling-7b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": ["<|end_of_turn|>"],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/stealth-v1.2-7b/model.json b/models/stealth-v1.2-7b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/tinyllama-1.1b/model.json b/models/tinyllama-1.1b/model.json
@@ -15,13 +15,14 @@
     "top_p": 0.95,
     "stream": true,
     "max_tokens": 2048,
+    "stop": [],
     "frequency_penalty": 0,
     "presence_penalty": 0
   },
   "metadata": {
       "author": "TinyLlama",
       "tags": ["Tiny", "Foundation Model"],
-      "size": 1170000000
+      "size": 669000000
   },
   "engine": "nitro"
 }
diff --git a/models/trinity-v1.2-7b/model.json b/models/trinity-v1.2-7b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/tulu-2-70b/model.json b/models/tulu-2-70b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/wizardcoder-13b/model.json b/models/wizardcoder-13b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/yarn-mistral-7b/model.json b/models/yarn-mistral-7b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/models/yi-34b/model.json b/models/yi-34b/model.json
@@ -15,6 +15,7 @@
       "top_p": 0.95,
       "stream": true,
       "max_tokens": 4096,
+      "stop": [],
       "frequency_penalty": 0,
       "presence_penalty": 0
     },

diff --git a/web/containers/CardSidebar/index.tsx b/web/containers/CardSidebar/index.tsx
@@ -5,12 +5,10 @@ import {
   ChevronDownIcon,
   MoreVerticalIcon,
   FolderOpenIcon,
-  Code2Icon,
   PencilIcon,
 } from 'lucide-react'
 import { twMerge } from 'tailwind-merge'
 
-import { useActiveModel } from '@/hooks/useActiveModel'
 import { useClickOutside } from '@/hooks/useClickOutside'
 
 import { activeThreadAtom } from '@/helpers/atoms/Thread.atom'
@@ -33,16 +31,15 @@ export default function CardSidebar({
   const [more, setMore] = useState(false)
   const [menu, setMenu] = useState<HTMLDivElement | null>(null)
   const [toggle, setToggle] = useState<HTMLDivElement | null>(null)
-  const { activeModel } = useActiveModel()
   const activeThread = useAtomValue(activeThreadAtom)
 
   useClickOutside(() => setMore(false), null, [menu, toggle])
 
   let openFolderTitle: string = 'Open Containing Folder'
   if (isMac) {
-    openFolderTitle = 'Reveal in Finder'
+    openFolderTitle = 'Show in Finder'
   } else if (isWindows) {
-    openFolderTitle = 'Reveal in File Explorer'
+    openFolderTitle = 'Show in File Explorer'
   }
 
   return (
@@ -108,7 +105,7 @@ export default function CardSidebar({
                 {title === 'Model' ? (
                   <div className="flex flex-col">
                     <span className="font-medium text-black dark:text-muted-foreground">
-                      Show in Finder
+                      {openFolderTitle}
                     </span>
                     <span className="mt-1 text-muted-foreground">
                       Opens thread.json. Changes affect this thread only.

diff --git a/web/hooks/useUpdateModelParameters.ts b/web/hooks/useUpdateModelParameters.ts
@@ -42,7 +42,9 @@ export default function useUpdateModelParameters() {
     }
     const updatedModelParams: ModelParams = {
       ...activeModelParams,
-      [name]: value,
+      // Explicitly set the value to an array if the name is 'stop'
+      // This is because the inference engine would only accept an array for the 'stop' parameter
+      [name]: name === 'stop' ? (value === '' ? [] : [value]) : value,
     }
 
     // update the state