MAT-1132 - fix review comments

llamanodes · May 10, 2020 · 462312f · 462312f
1 parent 9c5638e
commit 462312f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/bridge/setu/listener/rootchain.go b/bridge/setu/listener/rootchain.go
@@ -101,10 +101,12 @@ func (rl *RootChainListener) ProcessHeader(newHeader *types.Header) {
 
 	// confirmation
 	confirmationBlocks := big.NewInt(0).SetUint64(requiredConfirmations)
-	confirmationBlocks = confirmationBlocks.Add(confirmationBlocks, big.NewInt(1))
-	if latestNumber.Uint64() > confirmationBlocks.Uint64() {
-		latestNumber = latestNumber.Sub(latestNumber, confirmationBlocks)
+
+	if latestNumber.Cmp(confirmationBlocks) <= 0 {
+		rl.Logger.Error("Block number less than Confirmations required", "blockNumber", latestNumber.Uint64, "confirmationsRequired", confirmationBlocks.Uint64)
+		return
 	}
+	latestNumber = latestNumber.Sub(latestNumber, confirmationBlocks)
 
 	// default fromBlock
 	fromBlock := latestNumber