Skip to content

Commit

Permalink
Converting search to a dynamic feature and making it depend on app, i…
Browse files Browse the repository at this point in the history
…nstead of having app depend on it
florina-muntenescu committed Sep 28, 2018
1 parent 3300952 commit f7ab649
Showing 5 changed files with 8 additions and 6 deletions.
4 changes: 1 addition & 3 deletions app/build.gradle
Original file line number Diff line number Diff line change
@@ -63,7 +63,7 @@ android {
targetCompatibility JavaVersion.VERSION_1_8
}

dynamicFeatures = [':about', ':designernews', ':dribbble']
dynamicFeatures = [':about', ':designernews', ':dribbble', ':search']
}

repositories {
@@ -75,8 +75,6 @@ repositories {
dependencies {
api project(':core')

implementation project(':search')

implementation "com.crashlytics.sdk.android:crashlytics:${versions.crashlytics}"
implementation "com.google.firebase:firebase-core:${versions.firebase}"

4 changes: 4 additions & 0 deletions app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -49,4 +49,8 @@
<string name="share">share</string>
<string name="prospects_cant_post">Sorry but prospects cannot comment :(</string>
<string name="bad_dribbble_shot_url">Can\'t open that link :(</string>

<!--searchable label-->
<string name="search_hint">Search Dribbble &amp; Designer News</string>

</resources>
File renamed without changes.
4 changes: 2 additions & 2 deletions search/build.gradle
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
*
*/

apply plugin: 'com.android.library'
apply plugin: 'com.android.dynamic-feature'

android {
compileSdkVersion versions.compileSdk
@@ -37,5 +37,5 @@ repositories {
}

dependencies {
implementation project(':core')
implementation project(':app')
}
2 changes: 1 addition & 1 deletion search/src/main/res/layout/activity_search.xml
Original file line number Diff line number Diff line change
@@ -104,7 +104,7 @@
android:visibility="gone" />

<ImageButton
android:id="@id/fab"
android:id="@+id/fab"
android:layout_width="@dimen/fab_size"
android:layout_height="@dimen/fab_size"
android:layout_gravity="bottom|end"

0 comments on commit f7ab649

Please sign in to comment.