Marked non-extensible classes as sealed

LibGit2Sharp.Tests/MetaFixture.cs

@@ -10,20 +10,6 @@ namespace LibGit2Sharp.Tests
 {
     public class MetaFixture
     {
-        private static readonly Type[] excludedTypes = new[]
-        {
-            typeof(CheckoutOptions),
-            typeof(CommitFilter),
-            typeof(CommitRewriteInfo),
-            typeof(CompareOptions),
-            typeof(Credentials),
-            typeof(ExplicitPathsOptions),
-            typeof(ObjectId),
-            typeof(Repository),
-            typeof(RepositoryOptions),
-            typeof(Signature),
-        };
-
         // Related to https://github.com/libgit2/libgit2sharp/pull/251
         [Fact]
         public void TypesInLibGit2DecoratedWithDebuggerDisplayMustFollowTheStandardImplPattern()
@@ -71,7 +57,7 @@ public void TypesInLibGit2SharpMustBeExtensibleInATestingContext()
             var nonTestableTypes = new Dictionary<Type, IEnumerable<string>>();
 
             IEnumerable<Type> libGit2SharpTypes = Assembly.GetAssembly(typeof(Repository)).GetExportedTypes()
-                .Where(t => !excludedTypes.Contains(t) && t.Namespace == typeof(Repository).Namespace && !t.IsSubclassOf(typeof(Delegate)));
+                .Where(t => !t.IsSealed && t.Namespace == typeof(Repository).Namespace);
 
             foreach (Type type in libGit2SharpTypes)
             {

LibGit2Sharp/CheckoutOptions.cs

@@ -5,7 +5,7 @@ namespace LibGit2Sharp
     /// <summary>
     /// Collection of parameters controlling Checkout behavior.
     /// </summary>
-    public class CheckoutOptions
+    public sealed class CheckoutOptions
     {
         /// <summary>
         /// Options controlling checkout behavior.

LibGit2Sharp/CommitFilter.cs

@@ -7,7 +7,7 @@ namespace LibGit2Sharp
     /// <summary>
     /// Criterias used to filter out and order the commits of the repository when querying its history.
     /// </summary>
-    public class CommitFilter
+    public sealed class CommitFilter
     {
         /// <summary>
         /// Initializes a new instance of <see cref="CommitFilter"/>.

LibGit2Sharp/CommitRewriteInfo.cs

@@ -3,7 +3,7 @@ namespace LibGit2Sharp
     /// <summary>
     /// Commit metadata when rewriting history
     /// </summary>
-    public class CommitRewriteInfo
+    public sealed class CommitRewriteInfo
     {
         /// <summary>
         /// The author to be used for the new commit

LibGit2Sharp/CompareOptions.cs

@@ -3,7 +3,7 @@ namespace LibGit2Sharp
     /// <summary>
     /// Options to define file comparison behavior.
     /// </summary>
-    public class CompareOptions
+    public sealed class CompareOptions
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="CompareOptions"/> class.

LibGit2Sharp/Credentials.cs

@@ -3,7 +3,7 @@
     /// <summary>
     /// Class that holds credentials for remote repository access.
     /// </summary>
-    public class Credentials
+    public sealed class Credentials
     {
         /// <summary>
         /// Username for username/password authentication (as in HTTP basic auth).

LibGit2Sharp/ExplicitPathsOptions.cs

@@ -10,7 +10,7 @@ namespace LibGit2Sharp
     ///   explicit paths, and NOT pathspecs containing globs.
     /// </para>
     /// </summary>
-    public class ExplicitPathsOptions
+    public sealed class ExplicitPathsOptions
     {
         /// <summary>
         /// Associated paths will be treated as explicit paths.

LibGit2Sharp/ObjectId.cs

@@ -8,7 +8,7 @@ namespace LibGit2Sharp
     /// <summary>
     /// Uniquely identifies a <see cref="GitObject"/>.
     /// </summary>
-    public class ObjectId : IEquatable<ObjectId>
+    public sealed class ObjectId : IEquatable<ObjectId>
     {
         private readonly GitOid oid;
         private const int rawSize = 20;
@@ -17,7 +17,7 @@ public class ObjectId : IEquatable<ObjectId>
         /// <summary>
         /// Size of the string-based representation of a SHA-1.
         /// </summary>
-        protected const int HexSize = rawSize * 2;
+        private const int HexSize = rawSize * 2;
 
         private const string hexDigits = "0123456789abcdef";
         private static readonly byte[] reverseHexDigits = BuildReverseHexDigits();
@@ -85,7 +85,7 @@ public byte[] RawId
         /// <summary>
         /// Gets the sha.
         /// </summary>
-        public virtual string Sha
+        public string Sha
         {
             get { return sha; }
         }

LibGit2Sharp/Repository.cs

@@ -17,7 +17,7 @@ namespace LibGit2Sharp
     /// A Repository is the primary interface into a git repository
     /// </summary>
     [DebuggerDisplay("{DebuggerDisplay,nq}")]
-    public class Repository : IRepository
+    public sealed class Repository : IRepository
     {
         private readonly bool isBare;
         private readonly BranchCollection branches;
@@ -347,7 +347,7 @@ public void Dispose()
         /// <summary>
         /// Performs application-defined tasks associated with freeing, releasing, or resetting unmanaged resources.
         /// </summary>
-        protected virtual void Dispose(bool disposing)
+        private void Dispose(bool disposing)
         {
             CleanupDisposableDependencies();
         }
@@ -960,7 +960,7 @@ private IEnumerable<Commit> RetrieveParentsOfTheCommitBeingCreated(bool amendPre
         /// <summary>
         /// Clean the working tree by removing files that are not under version control.
         /// </summary>
-        public virtual void RemoveUntrackedFiles()
+        public void RemoveUntrackedFiles()
         {
             var options = new GitCheckoutOpts
             {
@@ -1036,7 +1036,7 @@ private static string ReadContentFromResource(Assembly assembly, string partialR
         /// <summary>
         /// Gets the references to the tips that are currently being merged.
         /// </summary>
-        public virtual IEnumerable<MergeHead> MergeHeads
+        public IEnumerable<MergeHead> MergeHeads
         {
             get
             {

LibGit2Sharp/RepositoryOptions.cs

@@ -3,7 +3,7 @@
     /// <summary>
     /// Provides optional additional information to the Repository to be opened.
     /// </summary>
-    public class RepositoryOptions
+    public sealed class RepositoryOptions
     {
         /// <summary>
         /// Overrides the probed location of the working directory of a standard repository,

LibGit2Sharp/Signature.cs

@@ -8,7 +8,7 @@ namespace LibGit2Sharp
     /// <summary>
     /// A signature
     /// </summary>
-    public class Signature : IEquatable<Signature>
+    public sealed class Signature : IEquatable<Signature>
     {
         private readonly DateTimeOffset when;
         private readonly string name;