Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace remaining bincode calls with wire. #946

Merged
merged 3 commits into from
Dec 18, 2024
Merged

refactor: Replace remaining bincode calls with wire. #946

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff3f033
Replace remaining bincode calls with wire.
AlejandroCabeza Dec 17, 2024
60e07ce
Remove bincode dependencies.
AlejandroCabeza Dec 17, 2024
da245dc
Remove call to bincode.
AlejandroCabeza Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove call to bincode.
  • Loading branch information
@AlejandroCabeza
AlejandroCabeza committed Dec 18, 2024
commit da245dcc8b9e6b655bb9814b850dd11704585831
3 changes: 2 additions & 1 deletion nomos-da/network/core/src/protocols/sampling/behaviour.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ use libp2p::swarm::{
use libp2p::{Multiaddr, PeerId, Stream};
use libp2p_stream::{Control, IncomingStreams, OpenStreamError};
use nomos_core::da::BlobId;
use nomos_core::wire;
use nomos_da_messages::packing::{pack_to_writer, unpack_from_reader};
use nomos_da_messages::{common, sampling};
use subnetworks_assignations::MembershipHandler;
Expand Down Expand Up @@ -56,7 +57,7 @@ pub enum SamplingError {
blob_id: BlobId,
subnetwork_id: SubnetworkId,
peer_id: PeerId,
error: bincode::Error,
error: wire::Error,
},
#[error("Error sending request: {request:?}")]
RequestChannel {
Expand Down
Loading