Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for RN check if addEventListener & removeEventListener are available #34

Merged
merged 3 commits into from
Nov 5, 2019

Conversation

CanRau
Copy link
Contributor

@CanRau CanRau commented Nov 5, 2019

No description provided.

@ai
Copy link
Member

ai commented Nov 5, 2019

LGTM. I will need a few hours to release it. Hope it is OK.

@CanRau
Copy link
Contributor Author

CanRau commented Nov 5, 2019

Sure no hurry, I just pushed the cross-tab-client changes, too

@CanRau
Copy link
Contributor Author

CanRau commented Nov 5, 2019

confirm.js has window.addEventListener as well but is only meant for browser, right, so maybe it's okay as is?

@ai
Copy link
Member

ai commented Nov 5, 2019

confirm.js has window.addEventListener as well but is only meant for browser, right, so maybe it's okay as is?

SSR is still a problem? Can I ask you ti fix it there too, since I will not have time in next hour?

@CanRau
Copy link
Contributor Author

CanRau commented Nov 5, 2019

done

@ai ai merged commit 14504f0 into logux:master Nov 5, 2019
@ai
Copy link
Member

ai commented Nov 5, 2019

Released in 0.5.2. Thanks for making PR and experiementing with RN support.

@CanRau
Copy link
Contributor Author

CanRau commented Nov 5, 2019

Thanks for this awesome project and guiding me so nicely 👍 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants