Fixed undefined global in the Browser in indexed-store/index.js #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per Gitter post with Andrey
Function in this module that use ``global`` would raise an exception because it is undefined in the Browser. ex. ``clean()`` & ``db.onversionchange()``
ai
reviewed
May 6, 2020
|
Yep. I'm fine with your change. I've made that change in my fork but can't do a pull request! |
|
Just add new commits to your |
|
Looks like you have the new commit now. |
|
Yeap, but I do not see changes for https://github.com/clibu/client/blob/16f790f56c55a7e4adde19a7029b197b1b6ebcd0/indexed-store/index.js#L74 Also, I recommend to install dependencies and run linter. It will tell you what to fix: yarn install
yarn test |
|
Ok, so is this what you are thinking: and etc. |
|
Yeap, I like it! |
/home/travis/build/logux/client/indexed-store/index.js 3:1 error This line has a length of 135. Maximum allowed is 80 max-len 3:18 error There should be no space after this paren space-in-parens 3:61 error There should be no space before this paren space-in-parens 3:81 error Multiple spaces found before '// global is u...' no-multi-spaces
4:1 error This line has a length of 82. Maximum allowed is 80 max-len 4:79 error Trailing spaces not allowed no-trailing-spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.