Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper regex for 127.* localhost detection #8

Merged
merged 2 commits into from
Jan 13, 2017
Merged

Use proper regex for 127.* localhost detection #8

merged 2 commits into from
Jan 13, 2017

Conversation

devgru
Copy link
Contributor

@devgru devgru commented Jan 11, 2017

No description provided.

@ai
Copy link
Member

ai commented Jan 11, 2017

  1. Add test
  2. Could you reduce RegExp size. It should not be 100% accurate. It is client side library, we should take care about file size. Especially for this dev things.

@ai ai merged commit 1cfb99b into logux:master Jan 13, 2017
ai pushed a commit that referenced this pull request Jul 31, 2018
@devgru @ai
Use proper regex for 127.* localhost detection (#8)
366e351 
* Use proper regex for 127.* localhost detection

* Shorten 127.* regexp, add one more test case for it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devgru @ai