FIX: VTK Version (mne-tools#10399)

lokinou · Mar 1, 2022 · 7214707 · 7214707
1 parent 3a79a23
commit 7214707
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/doc/changes/latest.inc b/doc/changes/latest.inc
@@ -167,6 +167,8 @@ Bugs
 
 - :func:`~mne.sys_info` output now contains the installed version of ``pooch``, too; this output had been accidentally removed previously (:gh:`10047` by `Richard Höchenberger`_)
 
+- Fix VTK version extraction in :func:`mne.sys_info` (:gh:`10399` by `Eric Larson`_)
+
 - Fix automatic channel type detection from channel labels in :func:`mne.io.read_raw_edf` and :func:`mne.io.read_raw_bdf` (and disable this functionality from :func:`mne.io.read_raw_gdf`) (:gh:`10058` by `Clemens Brunner`_)
 
 - Fix :func:`~mne.stats.permutation_cluster_1samp_test` to properly handle 2-dimensional data in combination with TFCE (:gh:`10073` by `Richard Höchenberger`_)

diff --git a/mne/utils/config.py b/mne/utils/config.py
@@ -599,12 +599,15 @@ def sys_info(fid=None, show_paths=False, *, dependencies='user'):
                 else:
                     extra += f' {{OpenGL {version} via {renderer}}}'
             if mod_name == 'vtk':
-                version = mod.vtkVersion()
+                vtk_version = mod.vtkVersion()
                 # 9.0 dev has VersionFull but 9.0 doesn't
                 for attr in ('GetVTKVersionFull', 'GetVTKVersion'):
-                    if hasattr(version, attr):
-                        version = getattr(version, attr)()
-                        break
+                    if hasattr(vtk_version, attr):
+                        version = getattr(vtk_version, attr)()
+                        if version != '':
+                            break
+                else:
+                    version = 'unknown'
             elif mod_name == 'PyQt5':
                 version = _check_pyqt5_version()
             else: