Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy lint group dependency #128

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

stankudrow
Copy link
Contributor

@stankudrow stankudrow commented Nov 9, 2024

Introducing the mypy type analyser under the lint dependency group alongside to the updated ruff linter.

The py.typed marker is placed into the package. Despite type stubs are not shipped yet, this marker lays the first stone.

Some minor sanity work was done for connection, errors and pool modules.

Thanks to this article for brief yet clean examples.

UPD: related to the issue #126 .

stankudrow pushed a commit to stankudrow/asynch that referenced this pull request Nov 9, 2024
@stankudrow
Copy link
Contributor Author

@long2ice , good day.

Can this PR go first, and then either #129 or #130 ?
The mypy library will enhance linting and code quality, also will be incorporated into the project CI/CD.

Thank you.

@stankudrow
Copy link
Contributor Author

stankudrow commented Nov 24, 2024

@long2ice , hello.

I have not addressed all mypy complaints, but the first brick is laid. If coping with issues piece by piece in every PR, the type hint problems may eventually disappear without lots of files to review at once.

A possible sequence: this PR -> #129 -> #130 and then a new release and closing the issues: #126, #121 and #127 .

@stankudrow
Copy link
Contributor Author

@long2ice , hello.

Is this PR is OK to be merged?

@stankudrow
Copy link
Contributor Author

@long2ice , hello.

The PR is rebased, if you don't mind, let's merge it before the PR #130 ?

@long2ice long2ice merged commit 088c7c5 into long2ice:dev Dec 16, 2024
1 check passed
@long2ice
Copy link
Owner

Thanks!

@stankudrow stankudrow deleted the add-mypy branch December 16, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants