Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/custom-modal-bottom-sheet-structure #45

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

lucasvps
Copy link
Contributor

@lucasvps lucasvps commented Jan 5, 2024

Changes:

1. What i did:

  • Fix custom modal bottom sheet content structure

2. What to test:

  • Use the custom modal bottom sheet

How to get there

1. Flavor and login informations

flavor: staging

2. Steps

  • Implement the showCustomModalBottomSheet content anywhere

Observations:

1. Known issues

  • Put them here if there are any

2. Code review pratices

  • Unecessary prints/log (ctrl+f -> [ print( ] )
  • Unecessary comments (ctrl+f -> [ // ] )
  • Code organization
  • Naming of functions and variables
  • Repeated code

@lucasvps lucasvps merged commit ff74da0 into main Jan 25, 2024
1 check passed
@lucasvps lucasvps deleted the fix/custom-modal-bottom-sheet branch January 25, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants