-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated exclusions for GPIO #25767
updated exclusions for GPIO #25767
Conversation
I'll review this properly in a second, but it's failing the lint job because of a missing signoff line in the commit message. |
2ca04fb
to
3eeed9e
Compare
3eeed9e
to
fb5cb61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File updated, I removed the strap related signals that were excluded before, now with the PR about strap verification test, those signals are suppose to toggle.
114fe3d
to
3147233
Compare
25e4b1d
to
c6a616c
Compare
c6a616c
to
a522a93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to be review again
I think there is just one item remaining! Here |
a522a93
to
cf2b65c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for all the work tidying it up.
Signed-off-by: Marcelo Carvalho Faleiro de Almeida <[email protected]>
cf2b65c
to
4953f53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks!
New updates for the exclusion file for GPIO.