Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated exclusions for GPIO #25767

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

marcelocarvalhoLowRisc
Copy link
Contributor

New updates for the exclusion file for GPIO.

@marcelocarvalhoLowRisc marcelocarvalhoLowRisc requested a review from a team as a code owner January 3, 2025 10:56
@marcelocarvalhoLowRisc marcelocarvalhoLowRisc requested review from eshapira and removed request for a team January 3, 2025 10:56
@rswarbrick
Copy link
Contributor

I'll review this properly in a second, but it's failing the lint job because of a missing signoff line in the commit message.

Copy link
Contributor Author

@marcelocarvalhoLowRisc marcelocarvalhoLowRisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File updated, I removed the strap related signals that were excluded before, now with the PR about strap verification test, those signals are suppose to toggle.

@marcelocarvalhoLowRisc marcelocarvalhoLowRisc force-pushed the gpio_pr_cov branch 2 times, most recently from 114fe3d to 3147233 Compare February 14, 2025 17:14
@marcelocarvalhoLowRisc marcelocarvalhoLowRisc force-pushed the gpio_pr_cov branch 2 times, most recently from 25e4b1d to c6a616c Compare February 19, 2025 16:49
Copy link
Contributor Author

@marcelocarvalhoLowRisc marcelocarvalhoLowRisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be review again

@rswarbrick
Copy link
Contributor

I think there is just one item remaining! Here

rswarbrick
rswarbrick previously approved these changes Feb 26, 2025
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for all the work tidying it up.

@rswarbrick rswarbrick dismissed their stale review February 26, 2025 12:29

Gah! It failed lint.

Signed-off-by: Marcelo Carvalho Faleiro de Almeida <[email protected]>
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks!

@rswarbrick rswarbrick merged commit ba31e19 into lowRISC:master Feb 28, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants