[rstmgr] Port rstmgr_alert_info_test to DT
#26422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnrt
requested review from
pamaury
and removed request for
a team and
msfschaffner
jwnrt
force-pushed
the
rstmgr-alert-info
branch
from
cca7664 to
e5f538a
Compare
Signed-off-by: James Wainwright <[email protected]>
The `all_escalation_resets_test` needs to know the number of alerts as a compile-time value constant so that it can reason in a generic way over the alerts. Expose this as an enum constant in the global DT API along with other alert information. Signed-off-by: Alex Jones <[email protected]> (cherry picked from commit ffd84cd)
This was unused. Signed-off-by: James Wainwright <[email protected]>
Signed-off-by: James Wainwright <[email protected]>
Signed-off-by: James Wainwright <[email protected]>
Signed-off-by: James Wainwright <[email protected]>
Remove this dependency by retrieving a pointer to the test utilities from the Retention SRAM via the DT API rather than via a hardcoded Earlgrey constant. This API call cannot happen at compile-time, so an initialization function is introduced alongside corresponding NULL (uninitialized checks) in relevant test utility functions. The static assertions also depend on Earlgrey constants for the Retention SRAM size, but this information is not yet available through the DT API. Adds some conditional #ifdefs to handle this case whilst this information is not yet available. Signed-off-by: Alex Jones <[email protected]> (cherry picked from commit e7b9861)
Signed-off-by: James Wainwright <[email protected]>
jwnrt
force-pushed
the
rstmgr-alert-info
branch
from
e5f538a to
76cfe31
Compare
pamaury
approved these changes
Feb 26, 2025
AlexJones0
approved these changes
Feb 27, 2025
Comment on lines
+5
to
+15
| #include "dt/dt_alert_handler.h" | ||
| #include "dt/dt_aon_timer.h" | ||
| #include "dt/dt_flash_ctrl.h" | ||
| #include "dt/dt_i2c.h" | ||
| #include "dt/dt_kmac.h" | ||
| #include "dt/dt_otp_ctrl.h" | ||
| #include "dt/dt_pwrmgr.h" | ||
| #include "dt/dt_rstmgr.h" | ||
| #include "dt/dt_rv_core_ibex.h" | ||
| #include "dt/dt_rv_plic.h" | ||
| #include "dt/dt_spi_host.h" |
There was a problem hiding this comment.
Nit: it would be nice to have the // Generated. comment by these, for the sake of consistency with other tests/imports. Also on the dt/dt_flash_ctrl.h header in the #ifdef OPENTITAN_IS_EARLGREY section below.
| static_assert(kDtRvPlicCount > 0, "test requires a PLIC"); | ||
| static_assert(kDtRvCoreIbexCount > 0, "how did you make a top without a core?"); | ||
| static_assert(kDtAonTimerCount > 0, "test requires an AON timer"); | ||
| static_assert(kDtPwrmgrCount > 0, "test requires an AON timer"); |
There was a problem hiding this comment.
Bad copy/paste here: should be "test requires a pwrmgr".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've stolen two commits from here: #26418