Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sw,imm_rom_ext] Transfer DICE public keys to mutable ROM_EXT #26429

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

sasdf
Copy link
Contributor

@sasdf sasdf commented Feb 26, 2025

The previous PR #26409 transferred the public key ID to mutable ROM_EXT to validate the certificate. This is sufficient for the x509 variant, but not for the CWT variant, which uses public key contents to validate the UDS COSE Key. The manual e2e provisioning test //sw/host/provisioning/orchestrator/tests:e2e_emulation_dice_cwt_cw340_test can catch this error.

This commit fixes the test by putting the public key contents into the static dice region with the public key ID.

@sasdf sasdf changed the title [sw,imm_rom_ext] Transfer DICE public keys to mutable ROM_EXT. [sw,imm_rom_ext] Transfer DICE public keys to mutable ROM_EXT Feb 26, 2025
The previous PR lowRISC#26409 transferred the public key ID to mutable ROM_EXT
to validate the certificate. This is sufficient for the x509 variant,
but not for the CWT variant, which uses public key contents to validate
the UDS COSE Key. The manual e2e provisioning test
//sw/host/provisioning/orchestrator/tests:e2e_emulation_dice_cwt_cw340_test
can catch this error.

This commit fixes the test by putting the public key contents into the static
dice region with the public key ID.

Change-Id: Ic7b68869ce753bfd8f7505ac0570b59418065984
Signed-off-by: Yi-Hsuan Deng <[email protected]>
(cherry picked from commit 60d8e39)
@sasdf sasdf requested a review from timothytrippel February 26, 2025 15:35
@sasdf sasdf marked this pull request as ready for review February 26, 2025 15:35
@sasdf sasdf requested a review from a team as a code owner February 26, 2025 15:35
@timothytrippel timothytrippel merged commit f7dae6e into lowRISC:master Feb 26, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants