Skip to content

Commit

Permalink
Merge pull request ethereum#16172 from gluk256/244-light-client
Browse files Browse the repository at this point in the history
whisper: light client mode introduced
  • Loading branch information
gluk256 authored Feb 23, 2018
2 parents 89f914c + d7b4b40 commit 4702ace
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 4 deletions.
12 changes: 12 additions & 0 deletions whisper/whisperv6/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,18 @@ func (api *PublicWhisperAPI) DeleteSymKey(ctx context.Context, id string) bool {
return api.w.DeleteSymKey(id)
}

// MakeLightClient turns the node into light client, which does not forward any incoming messages.
func (api *PublicWhisperAPI) MakeLightClient(ctx context.Context) bool {
api.w.lightClient = true
return api.w.lightClient
}

// CancelLightClient cancels light client mode.
func (api *PublicWhisperAPI) CancelLightClient(ctx context.Context) bool {
api.w.lightClient = false
return !api.w.lightClient
}

//go:generate gencodec -type NewMessage -field-override newMessageOverride -out gen_newmessage_json.go

// NewMessage represents a new whisper message that is posted through the RPC.
Expand Down
11 changes: 7 additions & 4 deletions whisper/whisperv6/whisper.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ type Whisper struct {

syncAllowance int // maximum time in seconds allowed to process the whisper-related messages

lightClient bool // indicates is this node is pure light client (does not forward any messages)

statsMu sync.Mutex // guard stats
stats Statistics // Statistics of whisper node

Expand Down Expand Up @@ -587,7 +589,7 @@ func (whisper *Whisper) Unsubscribe(id string) error {
// Send injects a message into the whisper send queue, to be distributed in the
// network in the coming cycles.
func (whisper *Whisper) Send(envelope *Envelope) error {
ok, err := whisper.add(envelope)
ok, err := whisper.add(envelope, false)
if err != nil {
return err
}
Expand Down Expand Up @@ -673,7 +675,7 @@ func (whisper *Whisper) runMessageLoop(p *Peer, rw p2p.MsgReadWriter) error {

trouble := false
for _, env := range envelopes {
cached, err := whisper.add(env)
cached, err := whisper.add(env, whisper.lightClient)
if err != nil {
trouble = true
log.Error("bad envelope received, peer will be disconnected", "peer", p.peer.ID(), "err", err)
Expand Down Expand Up @@ -746,7 +748,8 @@ func (whisper *Whisper) runMessageLoop(p *Peer, rw p2p.MsgReadWriter) error {
// add inserts a new envelope into the message pool to be distributed within the
// whisper network. It also inserts the envelope into the expiration pool at the
// appropriate time-stamp. In case of error, connection should be dropped.
func (whisper *Whisper) add(envelope *Envelope) (bool, error) {
// param isP2P indicates whether the message is peer-to-peer (should not be forwarded).
func (whisper *Whisper) add(envelope *Envelope, isP2P bool) (bool, error) {
now := uint32(time.Now().Unix())
sent := envelope.Expiry - envelope.TTL

Expand Down Expand Up @@ -811,7 +814,7 @@ func (whisper *Whisper) add(envelope *Envelope) (bool, error) {
whisper.statsMu.Lock()
whisper.stats.memoryUsed += envelope.size()
whisper.statsMu.Unlock()
whisper.postEvent(envelope, false) // notify the local node about the new message
whisper.postEvent(envelope, isP2P) // notify the local node about the new message
if whisper.mailServer != nil {
whisper.mailServer.Archive(envelope)
}
Expand Down

0 comments on commit 4702ace

Please sign in to comment.