[improvement] Checkbox: optimize performance (youzan#1057)

lrjxhchina · Dec 11, 2018 · b45b601 · b45b601
1 parent 97476fe
commit b45b601
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 13 deletions.
diff --git a/packages/checkbox-group/index.ts b/packages/checkbox-group/index.ts
@@ -16,9 +16,9 @@ VantComponent({
   },
 
   props: {
+    max: Number,
     value: Array,
-    disabled: Boolean,
-    max: Number
+    disabled: Boolean
   },
 
   watch: {

diff --git a/packages/checkbox/index.ts b/packages/checkbox/index.ts
@@ -23,16 +23,6 @@ VantComponent({
     }
   },
 
-  computed: {
-    iconStyle(): string {
-      const { value, disabled, checkedColor } = this.data;
-      if (checkedColor && value && !disabled) {
-        return `border-color: ${checkedColor}; background-color: ${checkedColor}`;
-      }
-      return '';
-    }
-  },
-
   methods: {
     emitChange(value) {
       const parent = this.getRelationNodes('../checkbox-group/index')[0];

diff --git a/packages/checkbox/index.wxml b/packages/checkbox/index.wxml
@@ -7,7 +7,7 @@
       wx:else
       name="success"
       class="{{ utils.bem('checkbox__icon', [shape, { disabled, checked: value }]) }}"
-      style="{{ iconStyle }}"
+      style="{{ checkedColor && value && !disabled ? 'border-color:' + checkedColor + '; background-color:' + checkedColor : '' }}"
       custom-class="icon-class"
       custom-style="line-height: 20px;"
     />