Skip to content

Commit

Permalink
Remove never read variable assignments (#95)
Browse files Browse the repository at this point in the history
In all 3 cases the variables are written again a few lines later. The
only purpose could be if xmlSecBufferGetSize() would have a side effect,
which is not the case.
  • Loading branch information
vmiklos authored and lsh123 committed Apr 1, 2017
1 parent 6c44213 commit fe256f6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/nss/x509.c
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,6 @@ xmlSecNssX509DataNodeRead(xmlSecKeyDataPtr data, xmlNodePtr node, xmlSecKeyInfoC
cur != NULL;
cur = xmlSecGetNextElementNode(cur->next)) {

ret = 0;
if(xmlSecCheckNodeName(cur, xmlSecNodeX509Certificate, xmlSecDSigNs)) {
ret = xmlSecNssX509CertificateNodeRead(data, cur, keyInfoCtx);
if(ret < 0) {
Expand Down
2 changes: 0 additions & 2 deletions src/transforms.c
Original file line number Diff line number Diff line change
Expand Up @@ -1915,8 +1915,6 @@ xmlSecTransformDefaultPushBin(xmlSecTransformPtr transform, const xmlSecByte* da
}

/* process data */
inSize = xmlSecBufferGetSize(&(transform->inBuf));
outSize = xmlSecBufferGetSize(&(transform->outBuf));
finalData = (((dataSize == 0) && (final != 0)) ? 1 : 0);
ret = xmlSecTransformExecute(transform, finalData, transformCtx);
if(ret < 0) {
Expand Down

0 comments on commit fe256f6

Please sign in to comment.